[PATCH net] MAINTAINERS: Add sctp headers to the general netdev entry

[PATCH net] MAINTAINERS: Add sctp headers to the general netdev entry

[Marcelo Ricardo Leitner]

All SCTP patches are picked up by netdev maintainers. Two headers were
missing to be listed there.

Reported-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 873aa2cce4d7fd5fd31613edbf3d99faaf7810bd..34ff998079d4c4843336936e47bd74c0e919012b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16509,6 +16509,7 @@ F:	include/linux/netdev*
 F:	include/linux/netlink.h
 F:	include/linux/netpoll.h
 F:	include/linux/rtnetlink.h
+F:	include/linux/sctp.h
 F:	include/linux/seq_file_net.h
 F:	include/linux/skbuff*
 F:	include/net/
@@ -16525,6 +16526,7 @@ F:	include/uapi/linux/netdev*
 F:	include/uapi/linux/netlink.h
 F:	include/uapi/linux/netlink_diag.h
 F:	include/uapi/linux/rtnetlink.h
+F:	include/uapi/linux/sctp.h
 F:	lib/net_utils.c
 F:	lib/random32.c
 F:	net/
-- 
2.48.1

Re: [PATCH net] MAINTAINERS: Add sctp headers to the general netdev entry

[Xin Long]

On Mon, Feb 10, 2025 at 8:25 AM Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
>
> All SCTP patches are picked up by netdev maintainers. Two headers were
> missing to be listed there.
>
> Reported-by: Thorsten Blum <thorsten.blum@linux.dev>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 873aa2cce4d7fd5fd31613edbf3d99faaf7810bd..34ff998079d4c4843336936e47bd74c0e919012b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16509,6 +16509,7 @@ F:      include/linux/netdev*
>  F:     include/linux/netlink.h
>  F:     include/linux/netpoll.h
>  F:     include/linux/rtnetlink.h
> +F:     include/linux/sctp.h
>  F:     include/linux/seq_file_net.h
>  F:     include/linux/skbuff*
>  F:     include/net/
> @@ -16525,6 +16526,7 @@ F:      include/uapi/linux/netdev*
>  F:     include/uapi/linux/netlink.h
>  F:     include/uapi/linux/netlink_diag.h
>  F:     include/uapi/linux/rtnetlink.h
> +F:     include/uapi/linux/sctp.h
>  F:     lib/net_utils.c
>  F:     lib/random32.c
>  F:     net/

Checking some other subcomponents like: MPTCP, TIPC, OPENVSWITCH,
HANDSHAKE UPCALL ...

It seems that we should append:

  L:      netdev@vger.kernel.org

after:

  L:      linux-sctp@vger.kernel.org

in the section:

  SCTP PROTOCOL

Re: [PATCH net] MAINTAINERS: Add sctp headers to the general netdev entry

[Marcelo Ricardo Leitner]

On Mon, Feb 10, 2025 at 11:44:10AM -0500, Xin Long wrote:
> On Mon, Feb 10, 2025 at 8:25 AM Marcelo Ricardo Leitner
> <marcelo.leitner@gmail.com> wrote:
> >
> > All SCTP patches are picked up by netdev maintainers. Two headers were
> > missing to be listed there.
> >
> > Reported-by: Thorsten Blum <thorsten.blum@linux.dev>
> > Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> > ---
> >  MAINTAINERS | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 873aa2cce4d7fd5fd31613edbf3d99faaf7810bd..34ff998079d4c4843336936e47bd74c0e919012b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16509,6 +16509,7 @@ F:      include/linux/netdev*
> >  F:     include/linux/netlink.h
> >  F:     include/linux/netpoll.h
> >  F:     include/linux/rtnetlink.h
> > +F:     include/linux/sctp.h
> >  F:     include/linux/seq_file_net.h
> >  F:     include/linux/skbuff*
> >  F:     include/net/
> > @@ -16525,6 +16526,7 @@ F:      include/uapi/linux/netdev*
> >  F:     include/uapi/linux/netlink.h
> >  F:     include/uapi/linux/netlink_diag.h
> >  F:     include/uapi/linux/rtnetlink.h
> > +F:     include/uapi/linux/sctp.h
> >  F:     lib/net_utils.c
> >  F:     lib/random32.c
> >  F:     net/
> 
> Checking some other subcomponents like: MPTCP, TIPC, OPENVSWITCH,
> HANDSHAKE UPCALL ...
> 
> It seems that we should append:
> 
>   L:      netdev@vger.kernel.org
> 
> after:
> 
>   L:      linux-sctp@vger.kernel.org
> 
> in the section:
> 
>   SCTP PROTOCOL

You mean, "also" append, right? And not "instead". Because currently
the NET one includes all other files and it doesn't exclude stuff like
net/{mptcp,sctp}.

Re: [PATCH net] MAINTAINERS: Add sctp headers to the general netdev entry

[Xin Long]

On Mon, Feb 10, 2025 at 12:35 PM Marcelo Ricardo Leitner
<marcelo.leitner@gmail.com> wrote:
>
> On Mon, Feb 10, 2025 at 11:44:10AM -0500, Xin Long wrote:
> > On Mon, Feb 10, 2025 at 8:25 AM Marcelo Ricardo Leitner
> > <marcelo.leitner@gmail.com> wrote:
> > >
> > > All SCTP patches are picked up by netdev maintainers. Two headers were
> > > missing to be listed there.
> > >
> > > Reported-by: Thorsten Blum <thorsten.blum@linux.dev>
> > > Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> > > ---
> > >  MAINTAINERS | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 873aa2cce4d7fd5fd31613edbf3d99faaf7810bd..34ff998079d4c4843336936e47bd74c0e919012b 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -16509,6 +16509,7 @@ F:      include/linux/netdev*
> > >  F:     include/linux/netlink.h
> > >  F:     include/linux/netpoll.h
> > >  F:     include/linux/rtnetlink.h
> > > +F:     include/linux/sctp.h
> > >  F:     include/linux/seq_file_net.h
> > >  F:     include/linux/skbuff*
> > >  F:     include/net/
> > > @@ -16525,6 +16526,7 @@ F:      include/uapi/linux/netdev*
> > >  F:     include/uapi/linux/netlink.h
> > >  F:     include/uapi/linux/netlink_diag.h
> > >  F:     include/uapi/linux/rtnetlink.h
> > > +F:     include/uapi/linux/sctp.h
> > >  F:     lib/net_utils.c
> > >  F:     lib/random32.c
> > >  F:     net/
> >
> > Checking some other subcomponents like: MPTCP, TIPC, OPENVSWITCH,
> > HANDSHAKE UPCALL ...
> >
> > It seems that we should append:
> >
> >   L:      netdev@vger.kernel.org
> >
> > after:
> >
> >   L:      linux-sctp@vger.kernel.org
> >
> > in the section:
> >
> >   SCTP PROTOCOL
>
> You mean, "also" append, right? And not "instead". Because currently
> the NET one includes all other files and it doesn't exclude stuff like
> net/{mptcp,sctp}.
I'm thinking it should be "instead".

Yes, all files under include/net/ are included in the NET, but those files
(belong to subcomponents/modules) under include/linux/, include/linux/uapi/
or even include/trace/ are included in their own sections and not in the
NET, such as:

include/uapi/linux/mptcp*.h
include/trace/events/mptcp.h
include/uapi/linux/tipc*.h
include/uapi/linux/openvswitch.h
include/trace/events/handshake.h

Thanks.

Re: [PATCH net] MAINTAINERS: Add sctp headers to the general netdev entry

[Simon Horman]

On Mon, Feb 10, 2025 at 10:24:55AM -0300, Marcelo Ricardo Leitner wrote:
> All SCTP patches are picked up by netdev maintainers. Two headers were
> missing to be listed there.
> 
> Reported-by: Thorsten Blum <thorsten.blum@linux.dev>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net] MAINTAINERS: Add sctp headers to the general netdev entry

[Jakub Kicinski]

On Mon, 10 Feb 2025 14:18:43 -0500 Xin Long wrote:
> > You mean, "also" append, right? And not "instead". Because currently
> > the NET one includes all other files and it doesn't exclude stuff like
> > net/{mptcp,sctp}.  
> I'm thinking it should be "instead".
> 
> Yes, all files under include/net/ are included in the NET, but those files
> (belong to subcomponents/modules) under include/linux/, include/linux/uapi/
> or even include/trace/ are included in their own sections and not in the
> NET, such as:

No strong preference TBH, but I think code and headers should fall
under the same entries. And net/sctp is not X:'ed out of net right 
now.

Re: [PATCH net] MAINTAINERS: Add sctp headers to the general netdev entry

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 10 Feb 2025 10:24:55 -0300 you wrote:
> All SCTP patches are picked up by netdev maintainers. Two headers were
> missing to be listed there.
> 
> Reported-by: Thorsten Blum <thorsten.blum@linux.dev>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)

Here is the summary with links:
  - [net] MAINTAINERS: Add sctp headers to the general netdev entry
    https://git.kernel.org/netdev/net/c/15d6f74f03f8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html