From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: Alexander Lobakin <aleksander.lobakin@intel.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Tariq Toukan <tariqt@nvidia.com>,
Louis Peens <louis.peens@corigine.com>,
Simon Horman <horms@kernel.org>, David Ahern <dsahern@kernel.org>,
Pravin B Shelar <pshelar@ovn.org>,
Yotam Gigi <yotam.gi@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
dev@openvswitch.org, linux-hardening@vger.kernel.org,
Ilya Maximets <i.maximets@ovn.org>,
Cosmin Ratiu <cratiu@nvidia.com>
Subject: Re: [PATCH net-next v2] net: Add options as a flexible array to struct ip_tunnel_info
Date: Wed, 12 Feb 2025 17:55:25 -0800 [thread overview]
Message-ID: <20250212175525.4e658590@kernel.org> (raw)
In-Reply-To: <d98d0c20-741d-4d87-b39e-5aa8eed4624c@nvidia.com>
On Wed, 12 Feb 2025 20:13:28 +0200 Gal Pressman wrote:
> > You could leave this macro inplace and just change `(info) + 1` to
> > `(info)->options` avoiding changes in lots of files and adding casts
> > everywhere.
+1
> I'd rather not, having a macro to do 'info->options' doesn't help code
> readability IMHO.
It'd avoid having to explicitly cast the types everywhere, too.
prev parent reply other threads:[~2025-02-13 1:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 14:09 [PATCH net-next v2] net: Add options as a flexible array to struct ip_tunnel_info Gal Pressman
2025-02-12 16:29 ` Alexander Lobakin
2025-02-12 18:13 ` Gal Pressman
2025-02-13 1:55 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212175525.4e658590@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=gustavoars@kernel.org \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=louis.peens@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=tariqt@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yotam.gi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).