From: Jakub Kicinski <kuba@kernel.org>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Yanteng Si <si.yanteng@linux.dev>,
Feiyang Chen <chris.chenfeiyang@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Serge Semin <fancer.lancer@gmail.com>,
loongarch@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Simon Horman <horms@kernel.org>,
Chong Qiao <qiaochong@loongson.cn>
Subject: Re: [PATCH net V2] net: stmmac: dwmac-loongson: Set correct {tx,rx}_fifo_size
Date: Wed, 12 Feb 2025 20:06:06 -0800 [thread overview]
Message-ID: <20250212200606.0638ed60@kernel.org> (raw)
In-Reply-To: <20250210134328.2755328-1-chenhuacai@loongson.cn>
On Mon, 10 Feb 2025 21:43:28 +0800 Huacai Chen wrote:
> Now for dwmac-loongson {tx,rx}_fifo_size are uninitialised, which means
> zero. This means dwmac-loongson doesn't support changing MTU because in
> stmmac_change_mtu() it requires the fifo size be no less than MTU. Thus,
> set the correct tx_fifo_size and rx_fifo_size for it (16KB multiplied by
> queue counts).
Not all drivers support changing MTU. Supporting jumbo frames
is a feature, so this commit enables the use of a feature.
As such it is not a fix. I'm applying this to net-next.
next prev parent reply other threads:[~2025-02-13 4:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 13:43 [PATCH net V2] net: stmmac: dwmac-loongson: Set correct {tx,rx}_fifo_size Huacai Chen
2025-02-13 4:06 ` Jakub Kicinski [this message]
2025-02-13 4:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212200606.0638ed60@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=chris.chenfeiyang@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=horms@kernel.org \
--cc=joabreu@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiaochong@loongson.cn \
--cc=si.yanteng@linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).