From: Jakub Kicinski <kuba@kernel.org>
To: Roger Quadros <rogerq@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Julien Panis <jpanis@baylibre.com>,
Jacob Keller <jacob.e.keller@intel.com>,
danishanwar@ti.com, s-vadapalli@ti.com, srk@ti.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH net 1/3] net: ethernet: ti: am65-cpsw: fix memleak in certain XDP cases
Date: Wed, 12 Feb 2025 20:14:30 -0800 [thread overview]
Message-ID: <20250212201430.5bfaecc7@kernel.org> (raw)
In-Reply-To: <20250210-am65-cpsw-xdp-fixes-v1-1-ec6b1f7f1aca@kernel.org>
On Mon, 10 Feb 2025 16:52:15 +0200 Roger Quadros wrote:
> - /* Compute additional headroom to be reserved */
> - headroom = (xdp.data - xdp.data_hard_start) - skb_headroom(skb);
> - skb_reserve(skb, headroom);
> + headroom = xdp.data - xdp.data_hard_start;
> + }
I'm gonna do a minor touch up here and set the headroom in "else" hope
you don't mind. Easier to read the code if the init isnt all the way up
at definition. Also that way reverse xmas tree is maintained.
next prev parent reply other threads:[~2025-02-13 4:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 14:52 [PATCH net 0/3] net: ethernet: ti: am65-cpsw: XDP fixes Roger Quadros
2025-02-10 14:52 ` [PATCH net 1/3] net: ethernet: ti: am65-cpsw: fix memleak in certain XDP cases Roger Quadros
2025-02-13 4:14 ` Jakub Kicinski [this message]
2025-02-14 11:39 ` Roger Quadros
2025-02-10 14:52 ` [PATCH net 2/3] net: ethernet: ti: am65-cpsw: fix RX & TX statistics for XDP_TX case Roger Quadros
2025-02-10 14:52 ` [PATCH net 3/3] net: ethernet: ti: am65_cpsw: fix tx_cleanup for XDP case Roger Quadros
2025-02-13 4:20 ` [PATCH net 0/3] net: ethernet: ti: am65-cpsw: XDP fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212201430.5bfaecc7@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=john.fastabend@gmail.com \
--cc=jpanis@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).