From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
willemb@google.com, shuah@kernel.org, petrm@nvidia.com
Subject: Re: [PATCH net-next 3/3] selftests: drv-net: add a simple TSO test
Date: Wed, 12 Feb 2025 20:18:14 -0800 [thread overview]
Message-ID: <20250212201814.168bd1fb@kernel.org> (raw)
In-Reply-To: <Z61dwqIp7PD_-m0B@mini-arch>
On Wed, 12 Feb 2025 18:49:38 -0800 Stanislav Fomichev wrote:
> > + if cfg.have_stat_super_count:
> > + ksft_lt(qstat_new['tx-hw-gso-packets'] -
> > + qstat_old['tx-hw-gso-packets'],
> > + 100, comment="Number of LSO super-packets with LSO disabled")
> > + if cfg.have_stat_wire_count:
> > + ksft_lt(qstat_new['tx-hw-gso-wire-packets'] -
> > + qstat_old['tx-hw-gso-wire-packets'],
> > + 1000, comment="Number of LSO wire-packets with LSO disabled")
>
> Why do you expect there to be some noise (100/1000) with the feature
> disabled?
We disable flag by flag. We may be disabling tunnel lso while some
background daemon is sending stuff with normal lso.
Looking at those numbers now, tho, I think I went a bit high.
100 * 64k = 6MB. We should probably set the noise to 10 super, 500 wire.
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-13 4:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 0:34 [PATCH net-next 0/3] selftests: drv-net: add a simple TSO test Jakub Kicinski
2025-02-13 0:34 ` [PATCH net-next 1/3] selftests: drv-net: resolve remote interface name Jakub Kicinski
2025-02-13 14:31 ` Petr Machata
2025-02-13 15:55 ` Jakub Kicinski
2025-02-13 16:23 ` Petr Machata
2025-02-13 0:34 ` [PATCH net-next 2/3] selftests: drv-net: get detailed interface info Jakub Kicinski
2025-02-13 14:39 ` Petr Machata
2025-02-13 0:34 ` [PATCH net-next 3/3] selftests: drv-net: add a simple TSO test Jakub Kicinski
2025-02-13 2:49 ` Stanislav Fomichev
2025-02-13 4:18 ` Jakub Kicinski [this message]
2025-02-13 16:02 ` Willem de Bruijn
2025-02-13 17:01 ` Jakub Kicinski
2025-02-13 16:01 ` Willem de Bruijn
2025-02-13 17:07 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212201814.168bd1fb@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=stfomichev@gmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).