netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
	willemb@google.com, ecree.xilinx@gmail.com, neescoba@cisco.com
Subject: Re: [PATCH net-next] netdev: clarify GSO vs csum in qstats
Date: Thu, 13 Feb 2025 07:48:51 -0800	[thread overview]
Message-ID: <20250213074851.7b4626e5@kernel.org> (raw)
In-Reply-To: <67ae123210650_24be45294bc@willemb.c.googlers.com.notmuch>

On Thu, 13 Feb 2025 10:39:30 -0500 Willem de Bruijn wrote:
> > +          calculated the L4 checksum (which means pretty much all of them).  
> 
> Can we clarify what pretty much here means?
> 
> TSO requires checksum offload. USO with zero checksum is the only exception that
> I can think of right now.

I was worried that somehow another case will appear and the comment
will become stale. I will just delete the part in the parenthesis.

      reply	other threads:[~2025-02-13 15:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13  1:04 [PATCH net-next] netdev: clarify GSO vs csum in qstats Jakub Kicinski
2025-02-13 15:39 ` Willem de Bruijn
2025-02-13 15:48   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250213074851.7b4626e5@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=neescoba@cisco.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).