From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, rdunlap@infradead.org,
bagasdotme@gmail.com, ahmed.zaki@intel.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] documentation: networking: Add NAPI config
Date: Thu, 13 Feb 2025 08:14:18 -0800 [thread overview]
Message-ID: <20250213081418.6d3966af@kernel.org> (raw)
In-Reply-To: <Z633ggyM-F2pfAkG@LQ3V64L9R2>
On Thu, 13 Feb 2025 05:45:38 -0800 Joe Damato wrote:
> On Thu, Feb 13, 2025 at 12:45:01PM +0100, Paolo Abeni wrote:
> > On 2/11/25 9:06 PM, Joe Damato wrote:
> > > +++ b/Documentation/networking/napi.rst
> > > @@ -171,12 +171,43 @@ a channel as an IRQ/NAPI which services queues
> > > of a given type. For example,
> >
> > It looks like your client mangled the patch; the above lines are
> > corrupted (there should be no line split)
> >
> > Please respin
>
> I must be missing something: I don't see the line split when looking
> at the original email and I just tried applying the patch directly
> from my email and it applied just fine.
>
> Are you sure its not something with your client?
>
> See the message on lore:
>
> https://lore.kernel.org/netdev/20250211151543.645d1c57@kernel.org/T/
It's also broken on lore.
The first diff block starting with the @@ line overflows and gets
broken into the next line. All lines within a diff block must start
with a space, + or -. The "of a given type. For example," line breaks
that.
next prev parent reply other threads:[~2025-02-13 16:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 20:06 [PATCH net-next v2] documentation: networking: Add NAPI config Joe Damato
2025-02-11 23:15 ` Jakub Kicinski
2025-02-12 9:31 ` Bagas Sanjaya
2025-02-13 11:45 ` Paolo Abeni
2025-02-13 13:45 ` Joe Damato
2025-02-13 16:14 ` Jakub Kicinski [this message]
2025-02-13 17:38 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213081418.6d3966af@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).