From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>,
Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH net] net: allow small head cache usage with large MAX_SKB_FRAGS values
Date: Thu, 13 Feb 2025 08:53:58 -0800 [thread overview]
Message-ID: <20250213085358.5a08e4c3@kernel.org> (raw)
In-Reply-To: <6bf54579233038bc0e76056c5ea459872ce362ab.1739375933.git.pabeni@redhat.com>
On Wed, 12 Feb 2025 18:42:32 +0100 Paolo Abeni wrote:
> In such built, SKB_WITH_OVERHEAD(1024) is smaller than GRO_MAX_HEAD, and
> thus after commit 011b03359038 ("Revert "net: skb: introduce and use a
> single page frag cache"") napi_get_frags() ends up using the page frag
> allocator, triggering the splat.
FTR I'll drop the revert from today's PR as discussed off list.
We can re-apply together with necessary adjustments.
prev parent reply other threads:[~2025-02-13 16:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 17:42 [PATCH net] net: allow small head cache usage with large MAX_SKB_FRAGS values Paolo Abeni
2025-02-12 20:47 ` Eric Dumazet
2025-02-12 22:08 ` Paolo Abeni
2025-02-13 13:44 ` Eric Dumazet
2025-02-13 17:12 ` Paolo Abeni
2025-02-13 17:29 ` Eric Dumazet
2025-02-17 14:48 ` Paolo Abeni
2025-02-18 13:43 ` Eric Dumazet
2025-02-18 14:50 ` Paolo Abeni
2025-02-18 17:16 ` Paolo Abeni
2025-02-18 17:38 ` Eric Dumazet
2025-02-13 16:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213085358.5a08e4c3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).