From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <kuniyu@amazon.com>
Cc: <apw@canonical.com>, <davem@davemloft.net>,
<dwaipayanray1@gmail.com>, <edumazet@google.com>,
<horms@kernel.org>, <joe@perches.com>, <kuba@kernel.org>,
<kuni1840@gmail.com>, <lukas.bulwahn@gmail.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH v1 net-next] checkpatch: Discourage a new use of rtnl_lock() variants.
Date: Thu, 13 Feb 2025 21:18:46 +0900 [thread overview]
Message-ID: <20250213121846.57655-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250213121028.48711-1-kuniyu@amazon.com>
From: Kuniyuki Iwashima <kuniyu@amazon.com>
Date: Thu, 13 Feb 2025 21:10:28 +0900
> > Also I'm unsure if the '^\+.*' header is strictly required - it should
> > but some/most existing tests don't use it, do you know why?
>
> I didn't notice but exactly, the following matches only + line.
>
> if ($line =~ /\brtnl_(try)?lock(_interruptible|_killable)?\s*\(\)/) {
>
> Looks like the '-' diff is filtered, matching '-' doesn't make sense.
>
> This function looks suspicious ? (maybe wrong, I'm not familiar with perl)
I was wrong, this part did the filtering :)
---8<---
#ignore lines not being added
next if ($line =~ /^[^\+]/);
---8<---
prev parent reply other threads:[~2025-02-13 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 7:04 [PATCH v1 net-next] checkpatch: Discourage a new use of rtnl_lock() variants Kuniyuki Iwashima
2025-02-12 18:23 ` Simon Horman
2025-02-13 11:03 ` Paolo Abeni
2025-02-13 12:10 ` Kuniyuki Iwashima
2025-02-13 12:18 ` Kuniyuki Iwashima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213121846.57655-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=dwaipayanray1@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=lukas.bulwahn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).