From: Jakub Kicinski <kuba@kernel.org>
To: Jeroen de Borst <jeroendb@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, willemb@google.com,
horms@kernel.org, Ziwei Xiao <ziweixiao@google.com>,
Harshitha Ramamurthy <hramamurthy@google.com>,
Praveen Kaligineedi <pkaligineedi@google.com>
Subject: Re: [PATCH net-next v3] gve: Add RSS cache for non RSS device option scenario
Date: Fri, 14 Feb 2025 06:38:45 -0800 [thread overview]
Message-ID: <20250214063845.5a9d2988@kernel.org> (raw)
In-Reply-To: <20250213233828.2044016-1-jeroendb@google.com>
On Thu, 13 Feb 2025 15:38:28 -0800 Jeroen de Borst wrote:
> - return gve_adminq_configure_rss(priv, rxfh);
> + err = gve_adminq_configure_rss(priv, rxfh);
> + if (err) {
> + NL_SET_ERR_MSG_MOD(extack, "Fail to configure RSS config\n");
coccicheck says:
drivers/net/ethernet/google/gve/gve_ethtool.c:915:29-61: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-14 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 23:38 [PATCH net-next v3] gve: Add RSS cache for non RSS device option scenario Jeroen de Borst
2025-02-14 14:38 ` Jakub Kicinski [this message]
2025-02-14 21:31 ` Ziwei Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214063845.5a9d2988@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).