From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Gregor Herburger <gregor.herburger@ew.tq-group.com>,
Stefan Eichenberger <eichest@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: phy: marvell-88q2xxx: align defines
Date: Fri, 14 Feb 2025 18:52:31 +0100 [thread overview]
Message-ID: <20250214175231.GC2392035@ragnatech.se> (raw)
In-Reply-To: <20250214-marvell-88q2xxx-cleanup-v1-1-71d67c20f308@gmail.com>
Hi Dimitri,
Thanks for your work.
On 2025-02-14 17:32:03 +0100, Dimitri Fedrau wrote:
> Align some defines.
>
> Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/net/phy/marvell-88q2xxx.c | 62 +++++++++++++++++++--------------------
> 1 file changed, 31 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/net/phy/marvell-88q2xxx.c b/drivers/net/phy/marvell-88q2xxx.c
> index bad5e7b2357da067bfd1ec6bd1307c42f5dc5c91..6e95de080bc65e8e8543d4effb9846fdd823a9d4 100644
> --- a/drivers/net/phy/marvell-88q2xxx.c
> +++ b/drivers/net/phy/marvell-88q2xxx.c
> @@ -12,29 +12,29 @@
> #include <linux/phy.h>
> #include <linux/hwmon.h>
>
> -#define PHY_ID_88Q2220_REVB0 (MARVELL_PHY_ID_88Q2220 | 0x1)
> -#define PHY_ID_88Q2220_REVB1 (MARVELL_PHY_ID_88Q2220 | 0x2)
> -#define PHY_ID_88Q2220_REVB2 (MARVELL_PHY_ID_88Q2220 | 0x3)
> -
> -#define MDIO_MMD_AN_MV_STAT 32769
> -#define MDIO_MMD_AN_MV_STAT_ANEG 0x0100
> -#define MDIO_MMD_AN_MV_STAT_LOCAL_RX 0x1000
> -#define MDIO_MMD_AN_MV_STAT_REMOTE_RX 0x2000
> -#define MDIO_MMD_AN_MV_STAT_LOCAL_MASTER 0x4000
> -#define MDIO_MMD_AN_MV_STAT_MS_CONF_FAULT 0x8000
> -
> -#define MDIO_MMD_AN_MV_STAT2 32794
> -#define MDIO_MMD_AN_MV_STAT2_AN_RESOLVED 0x0800
> -#define MDIO_MMD_AN_MV_STAT2_100BT1 0x2000
> -#define MDIO_MMD_AN_MV_STAT2_1000BT1 0x4000
> -
> -#define MDIO_MMD_PCS_MV_RESET_CTRL 32768
> -#define MDIO_MMD_PCS_MV_RESET_CTRL_TX_DISABLE 0x8
> -
> -#define MDIO_MMD_PCS_MV_INT_EN 32784
> -#define MDIO_MMD_PCS_MV_INT_EN_LINK_UP 0x0040
> -#define MDIO_MMD_PCS_MV_INT_EN_LINK_DOWN 0x0080
> -#define MDIO_MMD_PCS_MV_INT_EN_100BT1 0x1000
> +#define PHY_ID_88Q2220_REVB0 (MARVELL_PHY_ID_88Q2220 | 0x1)
> +#define PHY_ID_88Q2220_REVB1 (MARVELL_PHY_ID_88Q2220 | 0x2)
> +#define PHY_ID_88Q2220_REVB2 (MARVELL_PHY_ID_88Q2220 | 0x3)
> +
> +#define MDIO_MMD_AN_MV_STAT 32769
> +#define MDIO_MMD_AN_MV_STAT_ANEG 0x0100
> +#define MDIO_MMD_AN_MV_STAT_LOCAL_RX 0x1000
> +#define MDIO_MMD_AN_MV_STAT_REMOTE_RX 0x2000
> +#define MDIO_MMD_AN_MV_STAT_LOCAL_MASTER 0x4000
> +#define MDIO_MMD_AN_MV_STAT_MS_CONF_FAULT 0x8000
> +
> +#define MDIO_MMD_AN_MV_STAT2 32794
> +#define MDIO_MMD_AN_MV_STAT2_AN_RESOLVED 0x0800
> +#define MDIO_MMD_AN_MV_STAT2_100BT1 0x2000
> +#define MDIO_MMD_AN_MV_STAT2_1000BT1 0x4000
> +
> +#define MDIO_MMD_PCS_MV_RESET_CTRL 32768
> +#define MDIO_MMD_PCS_MV_RESET_CTRL_TX_DISABLE 0x8
> +
> +#define MDIO_MMD_PCS_MV_INT_EN 32784
> +#define MDIO_MMD_PCS_MV_INT_EN_LINK_UP 0x0040
> +#define MDIO_MMD_PCS_MV_INT_EN_LINK_DOWN 0x0080
> +#define MDIO_MMD_PCS_MV_INT_EN_100BT1 0x1000
>
> #define MDIO_MMD_PCS_MV_GPIO_INT_STAT 32785
> #define MDIO_MMD_PCS_MV_GPIO_INT_STAT_LINK_UP 0x0040
> @@ -80,11 +80,11 @@
> #define MDIO_MMD_PCS_MV_100BT1_STAT1_REMOTE_RX 0x2000
> #define MDIO_MMD_PCS_MV_100BT1_STAT1_LOCAL_MASTER 0x4000
>
> -#define MDIO_MMD_PCS_MV_100BT1_STAT2 33033
> -#define MDIO_MMD_PCS_MV_100BT1_STAT2_JABBER 0x0001
> -#define MDIO_MMD_PCS_MV_100BT1_STAT2_POL 0x0002
> -#define MDIO_MMD_PCS_MV_100BT1_STAT2_LINK 0x0004
> -#define MDIO_MMD_PCS_MV_100BT1_STAT2_ANGE 0x0008
> +#define MDIO_MMD_PCS_MV_100BT1_STAT2 33033
> +#define MDIO_MMD_PCS_MV_100BT1_STAT2_JABBER 0x0001
> +#define MDIO_MMD_PCS_MV_100BT1_STAT2_POL 0x0002
> +#define MDIO_MMD_PCS_MV_100BT1_STAT2_LINK 0x0004
> +#define MDIO_MMD_PCS_MV_100BT1_STAT2_ANGE 0x0008
>
> #define MDIO_MMD_PCS_MV_100BT1_INT_EN 33042
> #define MDIO_MMD_PCS_MV_100BT1_INT_EN_LINKEVENT 0x0400
> @@ -92,7 +92,7 @@
> #define MDIO_MMD_PCS_MV_COPPER_INT_STAT 33043
> #define MDIO_MMD_PCS_MV_COPPER_INT_STAT_LINKEVENT 0x0400
>
> -#define MDIO_MMD_PCS_MV_RX_STAT 33328
> +#define MDIO_MMD_PCS_MV_RX_STAT 33328
>
> #define MDIO_MMD_PCS_MV_TDR_RESET 65226
> #define MDIO_MMD_PCS_MV_TDR_RESET_TDR_RST 0x1000
> @@ -115,8 +115,8 @@
>
> #define MDIO_MMD_PCS_MV_TDR_OFF_CUTOFF 65246
>
> -#define MV88Q2XXX_LED_INDEX_TX_ENABLE 0
> -#define MV88Q2XXX_LED_INDEX_GPIO 1
> +#define MV88Q2XXX_LED_INDEX_TX_ENABLE 0
> +#define MV88Q2XXX_LED_INDEX_GPIO 1
>
> struct mv88q2xxx_priv {
> bool enable_temp;
>
> --
> 2.39.5
>
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2025-02-14 17:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 16:32 [PATCH net-next 0/3] net: phy: marvell-88q2xxx: cleanup Dimitri Fedrau
2025-02-14 16:32 ` [PATCH net-next 1/3] net: phy: marvell-88q2xxx: align defines Dimitri Fedrau
2025-02-14 17:52 ` Niklas Söderlund [this message]
2025-02-18 11:54 ` Marek Behún
2025-02-18 14:12 ` Andrew Lunn
2025-02-18 14:31 ` Marek Behún
2025-02-18 16:00 ` Russell King (Oracle)
2025-02-18 18:13 ` Dimitri Fedrau
2025-02-14 16:32 ` [PATCH net-next 2/3] net: phy: marvell-88q2xxx: order includes alphabetically Dimitri Fedrau
2025-02-14 17:53 ` Niklas Söderlund
2025-02-14 16:32 ` [PATCH net-next 3/3] net: phy: marvell-88q2xxx: enable temperature sensor in mv88q2xxx_config_init Dimitri Fedrau
2025-02-14 17:59 ` Niklas Söderlund
2025-02-14 19:45 ` Dimitri Fedrau
2025-02-20 15:37 ` Niklas Söderlund
2025-02-14 18:06 ` Andrew Lunn
2025-02-15 7:13 ` Dimitri Fedrau
2025-02-18 12:50 ` [PATCH net-next 0/3] net: phy: marvell-88q2xxx: cleanup patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214175231.GC2392035@ragnatech.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dima.fedrau@gmail.com \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=gregor.herburger@ew.tq-group.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).