[PATCH net-next] net: move stale comment about ntuple validation

[PATCH net-next] net: move stale comment about ntuple validation

[Jakub Kicinski]

Gal points out that the comment now belongs further down, since
the original if condition was split into two in
commit de7f7582dff2 ("net: ethtool: prevent flow steering to RSS contexts which don't exist")

Link: https://lore.kernel.org/de4a2a8a-1eb9-4fa8-af87-7526e58218e9@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: Gal Pressman <gal@nvidia.com>
CC: andrew@lunn.ch
CC: ecree.xilinx@gmail.com
---
 net/ethtool/ioctl.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
index 98b7dcea207a..271c7cef9ef3 100644
--- a/net/ethtool/ioctl.c
+++ b/net/ethtool/ioctl.c
@@ -992,8 +992,10 @@ static noinline_for_stack int ethtool_set_rxnfc(struct net_device *dev,
 	if (rc)
 		return rc;
 
-	/* Nonzero ring with RSS only makes sense if NIC adds them together */
 	if (cmd == ETHTOOL_SRXCLSRLINS && info.fs.flow_type & FLOW_RSS) {
+		/* Nonzero ring with RSS only makes sense
+		 * if NIC adds them together
+		 */
 		if (!ops->cap_rss_rxnfc_adds &&
 		    ethtool_get_flow_spec_ring(info.fs.ring_cookie))
 			return -EINVAL;
-- 
2.48.1

Re: [PATCH net-next] net: move stale comment about ntuple validation

[Gal Pressman]

On 15/02/2025 0:43, Jakub Kicinski wrote:
> Gal points out that the comment now belongs further down, since
> the original if condition was split into two in
> commit de7f7582dff2 ("net: ethtool: prevent flow steering to RSS contexts which don't exist")
> 
> Link: https://lore.kernel.org/de4a2a8a-1eb9-4fa8-af87-7526e58218e9@nvidia.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Thanks,
Reviewed-by: Gal Pressman <gal@nvidia.com>

Re: [PATCH net-next] net: move stale comment about ntuple validation

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 14 Feb 2025 14:43:40 -0800 you wrote:
> Gal points out that the comment now belongs further down, since
> the original if condition was split into two in
> commit de7f7582dff2 ("net: ethtool: prevent flow steering to RSS contexts which don't exist")
> 
> Link: https://lore.kernel.org/de4a2a8a-1eb9-4fa8-af87-7526e58218e9@nvidia.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net-next] net: move stale comment about ntuple validation
    https://git.kernel.org/netdev/net-next/c/637026e591fa

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html