From: Dimitri Fedrau <dima.fedrau@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Heiner Kallweit" <hkallweit1@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Gregor Herburger" <gregor.herburger@ew.tq-group.com>,
"Stefan Eichenberger" <eichest@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] net: phy: marvell-88q2xxx: enable temperature sensor in mv88q2xxx_config_init
Date: Sat, 15 Feb 2025 08:13:53 +0100 [thread overview]
Message-ID: <20250215071353.GA5691@debian> (raw)
In-Reply-To: <a3a5bd94-5bb7-4c65-85b6-d7876dca74b8@lunn.ch>
Am Fri, Feb 14, 2025 at 07:06:22PM +0100 schrieb Andrew Lunn:
> On Fri, Feb 14, 2025 at 05:32:05PM +0100, Dimitri Fedrau wrote:
> > Temperature sensor gets enabled for 88Q222X devices in
> > mv88q222x_config_init. Move enabling to mv88q2xxx_config_init because
> > all 88Q2XXX devices support the temperature sensor.
> >
> > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
>
> The change itself looks fine:
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> but is the sensor actually usable if the PHY has not yet been
> configured?
>
No.
> Architecturally, it seems odd to register the HWMON in probe, and then
> enable it in config_init.
I think it makes sense to enable it in probe as well. I just moved it to
config_init because of the PHYs hard reset. Before
https://lore.kernel.org/netdev/20250118-marvell-88q2xxx-fix-hwmon-v2-1-402e62ba2dcb@gmail.com/
it was already done in mv88q2xxx_hwmon_probe. I will come up with a patch.
Best regards,
Dimitri Fedrau
next prev parent reply other threads:[~2025-02-15 7:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 16:32 [PATCH net-next 0/3] net: phy: marvell-88q2xxx: cleanup Dimitri Fedrau
2025-02-14 16:32 ` [PATCH net-next 1/3] net: phy: marvell-88q2xxx: align defines Dimitri Fedrau
2025-02-14 17:52 ` Niklas Söderlund
2025-02-18 11:54 ` Marek Behún
2025-02-18 14:12 ` Andrew Lunn
2025-02-18 14:31 ` Marek Behún
2025-02-18 16:00 ` Russell King (Oracle)
2025-02-18 18:13 ` Dimitri Fedrau
2025-02-14 16:32 ` [PATCH net-next 2/3] net: phy: marvell-88q2xxx: order includes alphabetically Dimitri Fedrau
2025-02-14 17:53 ` Niklas Söderlund
2025-02-14 16:32 ` [PATCH net-next 3/3] net: phy: marvell-88q2xxx: enable temperature sensor in mv88q2xxx_config_init Dimitri Fedrau
2025-02-14 17:59 ` Niklas Söderlund
2025-02-14 19:45 ` Dimitri Fedrau
2025-02-20 15:37 ` Niklas Söderlund
2025-02-14 18:06 ` Andrew Lunn
2025-02-15 7:13 ` Dimitri Fedrau [this message]
2025-02-18 12:50 ` [PATCH net-next 0/3] net: phy: marvell-88q2xxx: cleanup patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250215071353.GA5691@debian \
--to=dima.fedrau@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=gregor.herburger@ew.tq-group.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).