Re: [PATCH net-next v2 00/11] net: Hold netdev instance lock during ndo operations

[Jakub Kicinski <kuba@kernel.org>]

On Fri, 14 Feb 2025 07:34:29 -0800 Stanislav Fomichev wrote:
> As the gradual purging of rtnl continues, start grabbing netdev
> instance lock in more places so we can get to the state where
> most paths are working without rtnl. Start with requiring the
> drivers that use shaper api (and later queue mgmt api) to work
> with both rtnl and netdev instance lock. Eventually we might
> attempt to drop rtnl. This mostly affects iavf, gve, bnxt and
> netdev sim (as the drivers that implement shaper/queue mgmt)
> so those drivers are converted in the process.
> 
> call_netdevice_notifiers locking is very inconsistent and might need
> a separate follow up. Some notified events are covered by the
> instance lock, some are not, which might complicate the driver
> expectations.

Appears to break the CI build:

net/core/dev.c:11392:12: error: ‘netdev_lock_cmp_fn’ defined but not used [-Werror=unused-function]
11392 | static int netdev_lock_cmp_fn(const struct lockdep_map *a,
      |            ^~~~~~~~~~~~~~~~~~
-- 
pw-bot: cr