From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D62F8634E; Sat, 15 Feb 2025 14:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739628070; cv=none; b=UPKUMdMCzR4EseavdWi7cRU3zEdbo/Go4pdZQMteyh37Mwy8IORtD+GPcpBxVQhR75JYz3zTf/4C05rbgeejeqvvRxRDUcRMGHchVYL6lHkbEi4cCR/s6W35af7AMyzYCjWoRXHw7iKuGnehqAJN06fhgCLI+QzympdtJ8TbZvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739628070; c=relaxed/simple; bh=3KZjQFG9kWj7eD82rZJTbZ9FPBolNJSFaZ87/g22y1A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X0AE3Vw5Pgc+XA1tSwRLZfDwZbt9F2J8ezrU00JY6R0NzwhZNWcCQ7xV+4ka9RYjIEvnELHKzraMSa4tocO5y4v3ODC1uguxSnI1+No5uBv4sGXKJ/zGBr1ztgwBcG7bwnD7jgUbqPTPcKBNnFsuQo8jHUVZRJpvzzfzx9IG3Jw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mdkeIjoa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mdkeIjoa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 822DEC4CEDF; Sat, 15 Feb 2025 14:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739628069; bh=3KZjQFG9kWj7eD82rZJTbZ9FPBolNJSFaZ87/g22y1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mdkeIjoaX5Cb1zuFkBFKRC5hh5M29XZV6OoodO/ZlM3RWcOllZD4faWThxIxKAilu /iuMlnTsVOmvaUlKMWzMz5ioNFJOXsiMMall0OHQ5poQv5AalO30eE62ksKJNLys9m avuff3LzCUsjxCRVh/t92j1yyH3H7FvPdXrKUOKmWJxLUey6VcZNnyDE1WeRjBfOt1 AAyWl08v6RedA0ScYvadnEDN2CwZ1fjFeeB+ivrxUOi3LQvWGLreBwFsweGGPCKke1 LDUWOLGA7xmCvobdxxd+EikL5WJC7hNXcHgTv8xCmhg8BHfFCEsi2cvputIOqUNCB7 SwzWhYoCaaffA== Date: Sat, 15 Feb 2025 14:01:04 +0000 From: Simon Horman To: Eric Woudstra Cc: Jakub Kicinski , Michal Swiatkowski , Felix Fietkau , Sean Wang , Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Frank Wunderlich , Daniel Golle , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3 net-next] net: ethernet: mtk_ppe_offload: Allow QinQ Message-ID: <20250215140104.GO1615191@kernel.org> References: <20250209110936.241487-1-ericwouds@gmail.com> <20250211165127.3282acb0@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Feb 12, 2025 at 08:33:52PM +0100, Eric Woudstra wrote: > > > On 2/12/25 1:51 AM, Jakub Kicinski wrote: > > On Sun, 9 Feb 2025 12:09:36 +0100 Eric Woudstra wrote: > >> This patch adds QinQ support to mtk_flow_offload_replace(). > >> > >> Only PPPoE-in-Q (as before) and Q-in-Q are allowed. A combination > >> of PPPoE and Q-in-Q is not allowed. > > > > AFAIU the standard asks for outer tag in Q-in-Q to be ETH_P_8021AD, > > but you still check: > > > >> act->vlan.proto != htons(ETH_P_8021Q)) > >> return -EOPNOTSUPP; > > > > If this is a HW limitation I think you should document that more > > clearly in the commit message. If you can fix it, I think you should.. > > It will be the first case. mtk_foe_entry_set_vlan() is limited to using > only 1 fixed protocol. I'll drop the reviewed-by, amend the commit > message and send v4. I agree with Jakub's comment regarding the spec, and his suggested actions. But, FWIIW, I also think that situations such as this are not uncommon in the wild.