[PATCH net-next] selftests: net: fix grammar in reuseaddr_ports_exhausted.c log message

[PATCH net-next] selftests: net: fix grammar in reuseaddr_ports_exhausted.c log message

[Pranav Tyagi]

This patch fixes a grammatical error in a test log message in
reuseaddr_ports_exhausted.c for better clarity as a part of lfx
application tasks

Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
---
 tools/testing/selftests/net/reuseaddr_ports_exhausted.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/reuseaddr_ports_exhausted.c b/tools/testing/selftests/net/reuseaddr_ports_exhausted.c
index 066efd30e294..7b9bf8a7bbe1 100644
--- a/tools/testing/selftests/net/reuseaddr_ports_exhausted.c
+++ b/tools/testing/selftests/net/reuseaddr_ports_exhausted.c
@@ -112,7 +112,7 @@ TEST(reuseaddr_ports_exhausted_reusable_same_euid)
 		ASSERT_NE(-1, fd[0]) TH_LOG("failed to bind.");
 
 		if (opts->reuseport[0] && opts->reuseport[1]) {
-			EXPECT_EQ(-1, fd[1]) TH_LOG("should fail to bind because both sockets succeed to be listened.");
+			EXPECT_EQ(-1, fd[1]) TH_LOG("should fail to bind because both sockets successfully listened.");
 		} else {
 			EXPECT_NE(-1, fd[1]) TH_LOG("should succeed to bind to connect to different destinations.");
 		}
-- 
2.47.1

Re: [PATCH net-next] selftests: net: fix grammar in reuseaddr_ports_exhausted.c log message

[Simon Horman]

On Thu, Feb 13, 2025 at 08:56:11PM +0530, Pranav Tyagi wrote:
> This patch fixes a grammatical error in a test log message in
> reuseaddr_ports_exhausted.c for better clarity as a part of lfx
> application tasks
> 
> Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>

Thanks Pranav,

This change looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>


A note on process to keep in mind for next time:

This patch seems to have been posted to netdev twice, about 20 hours apart.
Please don't do that as it can be quite confusing to reviewers.

If you need to update a patch, please version it (e.g. [PATCH v2 net-next).
If you need to repost a patch, say because there has been no response for a
long time, please label it accordingly (e.g. [PATCH REPOST net-next]) and
include some explanation of why it is being reposted, e.g. below the
scissors ("---").

And regardless, when posting a patch to netdev, please don't post it more
than once every 24h.

Re: [PATCH net-next] selftests: net: fix grammar in reuseaddr_ports_exhausted.c log message

[Pranav Tyagi]

Hi Simon,

Thank you for reviewing my patch and for the guidance on the submission process.

I sincerely apologize for the duplicate posting—I’ll make sure to
follow the correct versioning and reposting guidelines moving forward.
I’m still new to the community and getting familiar with the workflow,
so I really appreciate your feedback. I’ll keep these best practices
in mind for future submissions.

Regards,
Pranav Tyagi

On Sat, Feb 15, 2025 at 7:15 PM Simon Horman <horms@kernel.org> wrote:
>
> On Thu, Feb 13, 2025 at 08:56:11PM +0530, Pranav Tyagi wrote:
> > This patch fixes a grammatical error in a test log message in
> > reuseaddr_ports_exhausted.c for better clarity as a part of lfx
> > application tasks
> >
> > Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
>
> Thanks Pranav,
>
> This change looks good to me.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
>
>
> A note on process to keep in mind for next time:
>
> This patch seems to have been posted to netdev twice, about 20 hours apart.
> Please don't do that as it can be quite confusing to reviewers.
>
> If you need to update a patch, please version it (e.g. [PATCH v2 net-next).
> If you need to repost a patch, say because there has been no response for a
> long time, please label it accordingly (e.g. [PATCH REPOST net-next]) and
> include some explanation of why it is being reposted, e.g. below the
> scissors ("---").
>
> And regardless, when posting a patch to netdev, please don't post it more
> than once every 24h.

Re: [PATCH net-next] selftests: net: fix grammar in reuseaddr_ports_exhausted.c log message

[Simon Horman]

On Sat, Feb 15, 2025 at 11:53:33PM +0530, Pranav Tyagi wrote:
> Hi Simon,
> 
> Thank you for reviewing my patch and for the guidance on the submission process.
> 
> I sincerely apologize for the duplicate posting—I’ll make sure to
> follow the correct versioning and reposting guidelines moving forward.
> I’m still new to the community and getting familiar with the workflow,
> so I really appreciate your feedback. I’ll keep these best practices
> in mind for future submissions.

Thanks Pranav,

One more thing: please don't top-post on Kernel mailing lists.

Thanks!

Re: [PATCH net-next] selftests: net: fix grammar in reuseaddr_ports_exhausted.c log message

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 13 Feb 2025 20:56:11 +0530 you wrote:
> This patch fixes a grammatical error in a test log message in
> reuseaddr_ports_exhausted.c for better clarity as a part of lfx
> application tasks
> 
> Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
> ---
>  tools/testing/selftests/net/reuseaddr_ports_exhausted.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [net-next] selftests: net: fix grammar in reuseaddr_ports_exhausted.c log message
    https://git.kernel.org/netdev/net-next/c/dbcbec81c9b8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

[PATCH net-next] selftests: net: fix grammar in reuseaddr_ports_exhausted.c log message

[Pranav Tyagi]

This patch fixes a grammatical error in a test log message in
reuseaddr_ports_exhausted.c for better clarity as a part of lfx
application tasks

Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>
---
 tools/testing/selftests/net/reuseaddr_ports_exhausted.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/reuseaddr_ports_exhausted.c b/tools/testing/selftests/net/reuseaddr_ports_exhausted.c
index 066efd30e294..7b9bf8a7bbe1 100644
--- a/tools/testing/selftests/net/reuseaddr_ports_exhausted.c
+++ b/tools/testing/selftests/net/reuseaddr_ports_exhausted.c
@@ -112,7 +112,7 @@ TEST(reuseaddr_ports_exhausted_reusable_same_euid)
 		ASSERT_NE(-1, fd[0]) TH_LOG("failed to bind.");
 
 		if (opts->reuseport[0] && opts->reuseport[1]) {
-			EXPECT_EQ(-1, fd[1]) TH_LOG("should fail to bind because both sockets succeed to be listened.");
+			EXPECT_EQ(-1, fd[1]) TH_LOG("should fail to bind because both sockets successfully listened.");
 		} else {
 			EXPECT_NE(-1, fd[1]) TH_LOG("should succeed to bind to connect to different destinations.");
 		}
-- 
2.47.1

Re: [PATCH net-next] selftests: net: fix grammar in reuseaddr_ports_exhausted.c log message

[Simon Horman]

On Thu, Feb 13, 2025 at 12:24:12AM +0530, Pranav Tyagi wrote:
> This patch fixes a grammatical error in a test log message in
> reuseaddr_ports_exhausted.c for better clarity as a part of lfx
> application tasks
> 
> Signed-off-by: Pranav Tyagi <pranav.tyagi03@gmail.com>

This patch was also posted as:

- [PATCH net-next] selftests: net: fix grammar in reuseaddr_ports_exhausted.c log message
  https://lore.kernel.org/all/20250213152612.4434-1-pranav.tyagi03@gmail.com/

I will respond there.