From: Simon Horman <horms@kernel.org>
To: Peter Seiderer <ps.report@gmx.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Artem Chernyshev <artem.chernyshev@red-soft.ru>,
Nam Cao <namcao@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH net-next v5 7/8] net: pktgen: remove all superfluous index assignements
Date: Sun, 16 Feb 2025 14:15:03 +0000 [thread overview]
Message-ID: <20250216141503.GF1615191@kernel.org> (raw)
In-Reply-To: <20250213111920.1439021-8-ps.report@gmx.net>
On Thu, Feb 13, 2025 at 12:19:19PM +0100, Peter Seiderer wrote:
> Remove all superfluous index ('i += len') assignements (value not used
> afterwards).
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v4 -> v5
> - new patch (suggested by Simon Horman)
> ---
> net/core/pktgen.c | 52 ++++++-----------------------------------------
> 1 file changed, 6 insertions(+), 46 deletions(-)
Thanks Peter,
I went through each of these and they all seem to be cases
where i is incremented but the function returns without using
the new value of i.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-02-16 14:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 11:19 [PATCH net-next v5 0/8] Some pktgen fixes/improvments (part II) Peter Seiderer
2025-02-13 11:19 ` [PATCH net-next v5 1/8] net: pktgen: fix mix of int/long Peter Seiderer
2025-02-16 13:57 ` Simon Horman
2025-02-13 11:19 ` [PATCH net-next v5 2/8] net: pktgen: remove extra tmp variable (re-use len instead) Peter Seiderer
2025-02-13 11:19 ` [PATCH net-next v5 3/8] net: pktgen: remove some superfluous variable initializing Peter Seiderer
2025-02-13 11:19 ` [PATCH net-next v5 4/8] net: pktgen: fix mpls maximum labels list parsing Peter Seiderer
2025-02-16 13:58 ` Simon Horman
2025-02-13 11:19 ` [PATCH net-next v5 5/8] net: pktgen: fix access outside of user given buffer in pktgen_if_write() Peter Seiderer
2025-02-13 11:19 ` [PATCH net-next v5 6/8] net: pktgen: fix mpls reset parsing Peter Seiderer
2025-02-13 11:19 ` [PATCH net-next v5 7/8] net: pktgen: remove all superfluous index assignements Peter Seiderer
2025-02-16 14:15 ` Simon Horman [this message]
2025-02-13 11:19 ` [PATCH net-next v5 8/8] selftest: net: add proc_net_pktgen Peter Seiderer
2025-02-13 15:42 ` [PATCH net-next v5 0/8] Some pktgen fixes/improvments (part II) Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250216141503.GF1615191@kernel.org \
--to=horms@kernel.org \
--cc=artem.chernyshev@red-soft.ru \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frederic@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ps.report@gmx.net \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).