From: Jakub Kicinski <kuba@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com,
xiaoning.wang@nxp.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
ioana.ciornei@nxp.com, yangbo.lu@nxp.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
stable@vger.kernel.org
Subject: Re: [PATCH net 1/8] net: enetc: fix the off-by-one issue in enetc_map_tx_buffs()
Date: Mon, 17 Feb 2025 09:10:17 -0800 [thread overview]
Message-ID: <20250217091017.3779eaf5@kernel.org> (raw)
In-Reply-To: <20250217093906.506214-2-wei.fang@nxp.com>
On Mon, 17 Feb 2025 17:38:59 +0800 Wei Fang wrote:
> + while (count--) {
> tx_swbd = &tx_ring->tx_swbd[i];
> enetc_free_tx_frame(tx_ring, tx_swbd);
> if (i == 0)
> i = tx_ring->bd_count;
> i--;
> - } while (count--);
> + };
I think this gives us:
drivers/net/ethernet/freescale/enetc/enetc.c:408:2-3: Unneeded semicolon
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-17 17:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 9:38 [PATCH net 0/8] net: enetc: fix some known issues Wei Fang
2025-02-17 9:38 ` [PATCH net 1/8] net: enetc: fix the off-by-one issue in enetc_map_tx_buffs() Wei Fang
2025-02-17 13:11 ` Michal Swiatkowski
2025-02-18 2:11 ` Wei Fang
2025-02-18 5:45 ` Michal Swiatkowski
2025-02-18 6:08 ` Wei Fang
2025-02-17 17:10 ` Jakub Kicinski [this message]
2025-02-18 2:11 ` Wei Fang
2025-02-17 20:56 ` Claudiu Manoil
2025-02-18 2:02 ` Wei Fang
2025-02-18 9:02 ` Claudiu Manoil
2025-02-18 9:18 ` Wei Fang
2025-02-18 10:13 ` Claudiu Manoil
2025-02-17 9:39 ` [PATCH net 2/8] net: enetc: correct the tx_swbd statistics Wei Fang
2025-02-17 13:20 ` Michal Swiatkowski
2025-02-17 9:39 ` [PATCH net 3/8] net: enetc: correct the xdp_tx statistics Wei Fang
2025-02-17 9:39 ` [PATCH net 4/8] net: enetc: VFs do not support HWTSTAMP_TX_ONESTEP_SYNC Wei Fang
2025-02-17 9:39 ` [PATCH net 5/8] net: enetc: update UDP checksum when updating originTimestamp field Wei Fang
2025-02-17 9:39 ` [PATCH net 6/8] net: enetc: add missing enetc4_link_deinit() Wei Fang
2025-02-17 9:39 ` [PATCH net 7/8] net: enetc: remove the mm_lock from the ENETC v4 driver Wei Fang
2025-02-17 9:39 ` [PATCH net 8/8] net: enetc: correct the EMDIO base offset for ENETC v4 Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217091017.3779eaf5@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=ioana.ciornei@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).