From: Jakub Kicinski <kuba@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] rtnetlink: Allow setting IFLA_PERM_ADDRESS at device creation time
Date: Mon, 17 Feb 2025 09:51:50 -0800 [thread overview]
Message-ID: <20250217095150.12cdec05@kernel.org> (raw)
In-Reply-To: <87zfipom9q.fsf@toke.dk>
On Thu, 13 Feb 2025 17:13:53 +0100 Toke Høiland-Jørgensen wrote:
> Jakub Kicinski <kuba@kernel.org> writes:
>
> > On Thu, 13 Feb 2025 14:45:22 +0100 Toke Høiland-Jørgensen wrote:
> >> Eric suggested[0] allowing user-settable values for dev->perm_addr at
> >> device creation time, instead of mucking about with netdevsim to get a
> >> virtual device with a permanent address set.
> >
> > I vote no. Complicating the core so that its easier for someone
> > to write a unit test is the wrong engineering trade off.
> > Use a VM or netdevsim, that's what they are for.
>
> Hmm, and you don't see any value in being able to specify a permanent
> identifier for virtual devices? That bit was not just motivated
> reasoning on my part... :)
I can't think of any :( Specifying an address is already possible.
Permanent address is a property of the hardware platform.
Virtual devices OTOH are primarily used by containers,
which are ephemeral by design. At least that's my mental model.
next prev parent reply other threads:[~2025-02-17 17:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 13:45 [PATCH net-next] rtnetlink: Allow setting IFLA_PERM_ADDRESS at device creation time Toke Høiland-Jørgensen
2025-02-13 15:40 ` Jakub Kicinski
2025-02-13 16:13 ` Toke Høiland-Jørgensen
2025-02-17 17:51 ` Jakub Kicinski [this message]
2025-02-18 12:51 ` Toke Høiland-Jørgensen
2025-02-18 14:37 ` Jakub Kicinski
2025-02-18 20:14 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217095150.12cdec05@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).