netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<edumazet@google.com>, <horms@kernel.org>,
	<donald.hunter@gmail.com>, <dsahern@kernel.org>,
	<petrm@nvidia.com>, <gnault@redhat.com>,
	Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net-next 3/8] ipv4: fib_rules: Add port mask matching
Date: Mon, 17 Feb 2025 15:41:04 +0200	[thread overview]
Message-ID: <20250217134109.311176-4-idosch@nvidia.com> (raw)
In-Reply-To: <20250217134109.311176-1-idosch@nvidia.com>

Extend IPv4 FIB rules to match on source and destination ports using a
mask. Note that the mask is only set when not matching on a range.

Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
 include/net/fib_rules.h | 11 +++++++++++
 net/ipv4/fib_rules.c    |  8 ++++----
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h
index cfeb2fd0f5db..5927910ec06e 100644
--- a/include/net/fib_rules.h
+++ b/include/net/fib_rules.h
@@ -148,6 +148,17 @@ static inline bool fib_rule_port_inrange(const struct fib_rule_port_range *a,
 		ntohs(port) <= a->end;
 }
 
+static inline bool fib_rule_port_match(const struct fib_rule_port_range *range,
+				       u16 port_mask, __be16 port)
+{
+	if ((range->start ^ ntohs(port)) & port_mask)
+		return false;
+	if (!port_mask && fib_rule_port_range_set(range) &&
+	    !fib_rule_port_inrange(range, port))
+		return false;
+	return true;
+}
+
 static inline bool fib_rule_port_range_valid(const struct fib_rule_port_range *a)
 {
 	return a->start != 0 && a->end != 0 && a->end < 0xffff &&
diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c
index 041c46787d94..6b3d6a957822 100644
--- a/net/ipv4/fib_rules.c
+++ b/net/ipv4/fib_rules.c
@@ -201,12 +201,12 @@ INDIRECT_CALLABLE_SCOPE int fib4_rule_match(struct fib_rule *rule,
 	if (rule->ip_proto && (rule->ip_proto != fl4->flowi4_proto))
 		return 0;
 
-	if (fib_rule_port_range_set(&rule->sport_range) &&
-	    !fib_rule_port_inrange(&rule->sport_range, fl4->fl4_sport))
+	if (!fib_rule_port_match(&rule->sport_range, rule->sport_mask,
+				 fl4->fl4_sport))
 		return 0;
 
-	if (fib_rule_port_range_set(&rule->dport_range) &&
-	    !fib_rule_port_inrange(&rule->dport_range, fl4->fl4_dport))
+	if (!fib_rule_port_match(&rule->dport_range, rule->dport_mask,
+				 fl4->fl4_dport))
 		return 0;
 
 	return 1;
-- 
2.48.1


  parent reply	other threads:[~2025-02-17 13:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 13:41 [PATCH net-next 0/8] net: fib_rules: Add port mask support Ido Schimmel
2025-02-17 13:41 ` [PATCH net-next 1/8] net: fib_rules: Add port mask attributes Ido Schimmel
2025-02-17 13:41 ` [PATCH net-next 2/8] net: fib_rules: Add port mask support Ido Schimmel
2025-02-17 13:41 ` Ido Schimmel [this message]
2025-02-17 13:41 ` [PATCH net-next 4/8] ipv6: fib_rules: Add port mask matching Ido Schimmel
2025-02-17 13:41 ` [PATCH net-next 5/8] net: fib_rules: Enable port mask usage Ido Schimmel
2025-02-18 17:15   ` Kory Maincent
2025-02-18 18:15     ` Ido Schimmel
2025-02-18 19:22       ` Kory Maincent
2025-02-17 13:41 ` [PATCH net-next 6/8] netlink: specs: Add FIB rule port mask attributes Ido Schimmel
2025-02-17 13:41 ` [PATCH net-next 7/8] selftests: fib_rule_tests: Add port range match tests Ido Schimmel
2025-02-17 13:41 ` [PATCH net-next 8/8] selftests: fib_rule_tests: Add port mask " Ido Schimmel
2025-02-18 12:16 ` [PATCH net-next 0/8] net: fib_rules: Add port mask support Guillaume Nault
2025-02-19 15:22 ` David Ahern
2025-02-20  2:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250217134109.311176-4-idosch@nvidia.com \
    --to=idosch@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=gnault@redhat.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).