netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Suchit K <suchitkarunakaran@gmail.com>,
	netdev@vger.kernel.org, horms@kernel.org,
	linux-kernel-mentees@lists.linux.dev,
	linux-kernel@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH] selftests: net: Fix minor typos in MPTCP and psock_tpacket tests
Date: Mon, 17 Feb 2025 15:37:08 -0800	[thread overview]
Message-ID: <20250217153708.65269745@kernel.org> (raw)
In-Reply-To: <0c5f1dcf-1bd4-4ddd-b6c0-e3ee2b3671ea@kernel.org>

On Mon, 17 Feb 2025 11:08:36 +0100 Matthieu Baerts wrote:
> On 16/02/2025 13:25, Suchit K wrote:
> > Fixes minor spelling errors:
> > - `simult_flows.sh`: "al testcases" → "all testcases"
> > - `psock_tpacket.c`: "accross" → "across"  
> 
> The modifications in MPTCP (and psock_tpacket) look good to me:
> 
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Thanks! This patch is corrupted:

Applying: selftests: net: Fix minor typos in MPTCP and psock_tpacket tests
error: git diff header lacks filename information when removing 1 leading pathname component (line 7)
Patch failed at 0001 selftests: net: Fix minor typos in MPTCP and psock_tpacket tests
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Waiting for rebase to finish Mon Feb 17 03:34:36 PM PST 2025^C

So repost will be needed (unless Matt wants to take it into his tree
manually).

> This patch can be applied directly in the netdev tree, but I'm not sure
> the Netdev maintainers will accept that kind of small clean-up patch
> alone, see:
> 
>  https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches

FWIW spelling problems are explicitly called out as okay there.
-- 
pw-bot: cr

  reply	other threads:[~2025-02-17 23:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-16 12:25 [PATCH] selftests: net: Fix minor typos in MPTCP and psock_tpacket tests Suchit K
2025-02-17 10:08 ` Matthieu Baerts
2025-02-17 23:37   ` Jakub Kicinski [this message]
2025-02-18  9:28     ` Suchit K
2025-02-18 10:13     ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250217153708.65269745@kernel.org \
    --to=kuba@kernel.org \
    --cc=horms@kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=suchitkarunakaran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).