[PATCH] selftests: net: Fix minor typos in MPTCP and psock_tpacket tests

[PATCH] selftests: net: Fix minor typos in MPTCP and psock_tpacket tests

[Suchit K]

Fixes minor spelling errors:
- `simult_flows.sh`: "al testcases" → "all testcases"
- `psock_tpacket.c`: "accross" → "across"

Signed-off-by: Suchit Karunakaran <suchitkarunakaran@gmail.com>
---
 tools/testing/selftests/net/mptcp/simult_flows.sh | 2 +-
 tools/testing/selftests/net/psock_tpacket.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh
b/tools/testing/selftests/net/mptcp/simult_flows.sh
index 9c2a41597..2329c2f85 100755
--- a/tools/testing/selftests/net/mptcp/simult_flows.sh
+++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
@@ -28,7 +28,7 @@ size=0

 usage() {
  echo "Usage: $0 [ -b ] [ -c ] [ -d ] [ -i]"
- echo -e "\t-b: bail out after first error, otherwise runs al testcases"
+ echo -e "\t-b: bail out after first error, otherwise runs all testcases"
  echo -e "\t-c: capture packets for each test using tcpdump (default:
no capture)"
  echo -e "\t-d: debug this script"
  echo -e "\t-i: use 'ip mptcp' instead of 'pm_nl_ctl'"
diff --git a/tools/testing/selftests/net/psock_tpacket.c
b/tools/testing/selftests/net/psock_tpacket.c
index 404a2ce75..221270cee 100644
--- a/tools/testing/selftests/net/psock_tpacket.c
+++ b/tools/testing/selftests/net/psock_tpacket.c
@@ -12,7 +12,7 @@
  *
  * Datapath:
  *   Open a pair of packet sockets and send resp. receive an a priori known
- *   packet pattern accross the sockets and check if it was received resp.
+ *   packet pattern across the sockets and check if it was received resp.
  *   sent correctly. Fanout in combination with RX_RING is currently not
  *   tested here.
  *
-- 
2.48.1

Re: [PATCH] selftests: net: Fix minor typos in MPTCP and psock_tpacket tests

[Matthieu Baerts]

Hello,

On 16/02/2025 13:25, Suchit K wrote:
> Fixes minor spelling errors:
> - `simult_flows.sh`: "al testcases" → "all testcases"
> - `psock_tpacket.c`: "accross" → "across"

The modifications in MPTCP (and psock_tpacket) look good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

This patch can be applied directly in the netdev tree, but I'm not sure
the Netdev maintainers will accept that kind of small clean-up patch
alone, see:

 https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: [PATCH] selftests: net: Fix minor typos in MPTCP and psock_tpacket tests

[Jakub Kicinski]

On Mon, 17 Feb 2025 11:08:36 +0100 Matthieu Baerts wrote:
> On 16/02/2025 13:25, Suchit K wrote:
> > Fixes minor spelling errors:
> > - `simult_flows.sh`: "al testcases" → "all testcases"
> > - `psock_tpacket.c`: "accross" → "across"  
> 
> The modifications in MPTCP (and psock_tpacket) look good to me:
> 
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Thanks! This patch is corrupted:

Applying: selftests: net: Fix minor typos in MPTCP and psock_tpacket tests
error: git diff header lacks filename information when removing 1 leading pathname component (line 7)
Patch failed at 0001 selftests: net: Fix minor typos in MPTCP and psock_tpacket tests
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Waiting for rebase to finish Mon Feb 17 03:34:36 PM PST 2025^C

So repost will be needed (unless Matt wants to take it into his tree
manually).

> This patch can be applied directly in the netdev tree, but I'm not sure
> the Netdev maintainers will accept that kind of small clean-up patch
> alone, see:
> 
>  https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches

FWIW spelling problems are explicitly called out as okay there.
-- 
pw-bot: cr

Re: [PATCH] selftests: net: Fix minor typos in MPTCP and psock_tpacket tests

[Suchit K]

Hi Jakub. I've reposted the patch. Thanks.

On Tue, 18 Feb 2025 at 05:07, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 17 Feb 2025 11:08:36 +0100 Matthieu Baerts wrote:
> > On 16/02/2025 13:25, Suchit K wrote:
> > > Fixes minor spelling errors:
> > > - `simult_flows.sh`: "al testcases" → "all testcases"
> > > - `psock_tpacket.c`: "accross" → "across"
> >
> > The modifications in MPTCP (and psock_tpacket) look good to me:
> >
> > Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
> Thanks! This patch is corrupted:
>
> Applying: selftests: net: Fix minor typos in MPTCP and psock_tpacket tests
> error: git diff header lacks filename information when removing 1 leading pathname component (line 7)
> Patch failed at 0001 selftests: net: Fix minor typos in MPTCP and psock_tpacket tests
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> hint: When you have resolved this problem, run "git am --continue".
> hint: If you prefer to skip this patch, run "git am --skip" instead.
> hint: To restore the original branch and stop patching, run "git am --abort".
> hint: Disable this message with "git config set advice.mergeConflict false"
> Waiting for rebase to finish Mon Feb 17 03:34:36 PM PST 2025^C
>
> So repost will be needed (unless Matt wants to take it into his tree
> manually).
>
> > This patch can be applied directly in the netdev tree, but I'm not sure
> > the Netdev maintainers will accept that kind of small clean-up patch
> > alone, see:
> >
> >  https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches
>
> FWIW spelling problems are explicitly called out as okay there.
> --
> pw-bot: cr

Re: [PATCH] selftests: net: Fix minor typos in MPTCP and psock_tpacket tests

[Matthieu Baerts]

Hi Jakub,

On 18/02/2025 00:37, Jakub Kicinski wrote:
> On Mon, 17 Feb 2025 11:08:36 +0100 Matthieu Baerts wrote:

(...)

>> This patch can be applied directly in the netdev tree, but I'm not sure
>> the Netdev maintainers will accept that kind of small clean-up patch
>> alone, see:
>>
>>  https://docs.kernel.org/process/maintainer-netdev.html#clean-up-patches
> 
> FWIW spelling problems are explicitly called out as okay there.
Ah yes, sorry, I missed the last line of this section:

  Conversely, spelling and grammar fixes are not discouraged.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.