From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FBA979E1; Tue, 18 Feb 2025 00:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739838779; cv=none; b=QDxxf2Xv97UB+2wvbPdTETcNjDQhAi9jv7PKJgGTPBLm0UF3/qN7oXYvQn6qmyk+0he9aXpsr8fDV7zdJKVxLdH8wacePqlxrVP7sb7oG/CY0VpuUzpCSjMTd0emKayaan4yBONyZMoOyM/uE4KHHeFeYY/ndUnRBVTSSfVpuRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739838779; c=relaxed/simple; bh=7TsYm0VQroDLIwBtLeWiZg26n3x1/vAnj9r5cLl1Yys=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dCaU/j2nYsC80sH9vwbYvbVoH4Atz3tzyE3q1qqIX/1XCoyfeNKXWqwYjYnTbI9FgFfI36xwpUADu17+F6ovDL/fprRIhJUxoUNC02kMG7ycwkL4Gf0MSZSDI7bwwzXiUa3/65GSTQJxOOo3Sm/H7lcoBS0vLW528uJPJZYUddc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XSuYdJaf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XSuYdJaf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64615C4CED1; Tue, 18 Feb 2025 00:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739838778; bh=7TsYm0VQroDLIwBtLeWiZg26n3x1/vAnj9r5cLl1Yys=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XSuYdJafDRomcc3U5LvDDbZC82tRbN5EyNEI8WBqMehznMicBH0Gsnp5exaFarYMc qDZnf1Wu6uXAYL0WaC1R/BdMiQQsbeV9N8xbm7vdpECVRViy4wGWz3SmIXwcRaX5GW vtROAoeUHlmGOsjqhVF9DR19Y4+xd7uUYtQhycuu63NjXbf9W8emIjsJNCHUHm9reI 7d4TqX5LvW3waM1o6WV1R2s2+2qg+23Kk93X4mEJZ8ZPcfOm7T5YKax01ad5f6zdV2 SaoWMNK4BOe3dm9zwjX/U2iSbCEwWMGxq18nAWM2HkGyxkcCKAznd6MYdY+6vTCrMf SPqJ9GtY2gh/w== Date: Mon, 17 Feb 2025 16:32:56 -0800 From: Jakub Kicinski To: Breno Leitao Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , David Ahern , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , kuniyu@amazon.co.jp, ushankar@purestorage.com, kuniyu@amazon.com Subject: Re: [PATCH net v4 1/2] net: Add non-RCU dev_getbyhwaddr() helper Message-ID: <20250217163256.491b7990@kernel.org> In-Reply-To: <20250213-arm_fix_selftest-v4-1-26714529a6cf@debian.org> References: <20250213-arm_fix_selftest-v4-0-26714529a6cf@debian.org> <20250213-arm_fix_selftest-v4-1-26714529a6cf@debian.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 13 Feb 2025 04:42:37 -0800 Breno Leitao wrote: > +static bool dev_comp_addr(struct net_device *dev, unsigned short type, sorry for the nit, but: dev_comp_addr() -> dev_addr_cmp() ? cmp is the typical abbreviation for compare in C > + * dev_getbyhwaddr - find a device by its hardware address another tiny nit here: I think ideally there should be a () after the function name -- pw-bot: cr