* [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP
@ 2025-02-09 11:01 Birger Koblitz
2025-02-09 15:13 ` Daniel Golle
2025-02-12 3:02 ` Jakub Kicinski
0 siblings, 2 replies; 9+ messages in thread
From: Birger Koblitz @ 2025-02-09 11:01 UTC (permalink / raw)
To: netdev; +Cc: Daniel Golle, Jakub Kicinski
The OEM SFP-2.5G-BX10-D/U SFP module pair is meant to operate with
2500Base-X. However, in their EEPROM they incorrectly specify:
Transceiver codes : 0x00 0x12 0x00 0x00 0x12 0x00 0x01 0x05 0x00
BR, Nominal : 2500MBd
Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway.
Run-tested on BananaPi R3.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
---
drivers/net/phy/sfp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 7dbcbf0a4ee2..9369f5297769 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -515,6 +515,8 @@ static const struct sfp_quirk sfp_quirks[] = {
SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc),
SFP_QUIRK_M("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
+ SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex),
+ SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-U", sfp_quirk_2500basex),
SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc),
SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc),
SFP_QUIRK_F("Turris", "RTSFP-2.5G", sfp_fixup_rollball),
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP
2025-02-09 11:01 Birger Koblitz
@ 2025-02-09 15:13 ` Daniel Golle
2025-02-12 3:02 ` Jakub Kicinski
1 sibling, 0 replies; 9+ messages in thread
From: Daniel Golle @ 2025-02-09 15:13 UTC (permalink / raw)
To: Birger Koblitz; +Cc: netdev, Jakub Kicinski
On Sun, Feb 09, 2025 at 12:01:55PM +0100, Birger Koblitz wrote:
> The OEM SFP-2.5G-BX10-D/U SFP module pair is meant to operate with
> 2500Base-X. However, in their EEPROM they incorrectly specify:
> Transceiver codes : 0x00 0x12 0x00 0x00 0x12 0x00 0x01 0x05 0x00
> BR, Nominal : 2500MBd
>
> Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway.
> Run-tested on BananaPi R3.
>
> Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
> ---
> drivers/net/phy/sfp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index 7dbcbf0a4ee2..9369f5297769 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -515,6 +515,8 @@ static const struct sfp_quirk sfp_quirks[] = {
> SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc),
> SFP_QUIRK_M("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
> + SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex),
> + SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-U", sfp_quirk_2500basex),
> SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc),
> SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc),
> SFP_QUIRK_F("Turris", "RTSFP-2.5G", sfp_fixup_rollball),
> --
> 2.39.5
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP
2025-02-09 11:01 Birger Koblitz
2025-02-09 15:13 ` Daniel Golle
@ 2025-02-12 3:02 ` Jakub Kicinski
1 sibling, 0 replies; 9+ messages in thread
From: Jakub Kicinski @ 2025-02-12 3:02 UTC (permalink / raw)
To: Birger Koblitz; +Cc: netdev, Daniel Golle
On Sun, 9 Feb 2025 12:01:55 +0100 Birger Koblitz wrote:
> SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc),
The patch is corrupted, there is an extra space at the start
of each context line. Perhaps try resending with git send-email?
Before resending please add Daniel's review tag to the commit message.
> SFP_QUIRK_M("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
> + SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex),
> + SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-U", sfp_quirk_2500basex),
--
pw-bot: cr
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP
@ 2025-02-12 15:13 Birger Koblitz
2025-02-14 21:24 ` Jakub Kicinski
0 siblings, 1 reply; 9+ messages in thread
From: Birger Koblitz @ 2025-02-12 15:13 UTC (permalink / raw)
To: netdev; +Cc: Daniel Golle, Jakub Kicinski
The OEM SFP-2.5G-BX10-D/U SFP module pair is meant to operate with
2500Base-X. However, in their EEPROM they incorrectly specify:
Transceiver codes : 0x00 0x12 0x00 0x00 0x12 0x00 0x01 0x05 0x00
BR, Nominal : 2500MBd
Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway.
Run-tested on BananaPi R3.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/net/phy/sfp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 7dbcbf0a4ee2..9369f5297769 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -515,6 +515,8 @@ static const struct sfp_quirk sfp_quirks[] = {
SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc),
SFP_QUIRK_M("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
+ SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex),
+ SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-U", sfp_quirk_2500basex),
SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc),
SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc),
SFP_QUIRK_F("Turris", "RTSFP-2.5G", sfp_fixup_rollball),
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP
2025-02-12 15:13 Birger Koblitz
@ 2025-02-14 21:24 ` Jakub Kicinski
0 siblings, 0 replies; 9+ messages in thread
From: Jakub Kicinski @ 2025-02-14 21:24 UTC (permalink / raw)
To: Birger Koblitz; +Cc: netdev, Daniel Golle
On Wed, 12 Feb 2025 16:13:44 +0100 Birger Koblitz wrote:
> The OEM SFP-2.5G-BX10-D/U SFP module pair is meant to operate with
> 2500Base-X. However, in their EEPROM they incorrectly specify:
> Transceiver codes : 0x00 0x12 0x00 0x00 0x12 0x00 0x01 0x05 0x00
> BR, Nominal : 2500MBd
>
> Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway.
> Run-tested on BananaPi R3.
Still white space damaged :(
Could you try sending with git send-email or b4 ?
--
pw-bot: cr
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP
@ 2025-02-15 6:29 Birger Koblitz
2025-02-18 1:00 ` Jakub Kicinski
0 siblings, 1 reply; 9+ messages in thread
From: Birger Koblitz @ 2025-02-15 6:29 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, Birger Koblitz, Daniel Golle
The OEM SFP-2.5G-BX10-D/U SFP module pair is meant to operate with
2500Base-X. However, in their EEPROM they incorrectly specify:
Transceiver codes : 0x00 0x12 0x00 0x00 0x12 0x00 0x01 0x05 0x00
BR, Nominal : 2500MBd
Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway.
Tested on BananaPi R3.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/net/phy/sfp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 7dbcbf0a4ee26a221e9c47a6f030c8a18317bdbb..9369f5297769493efcab0ed4c356245baa1aa248 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -515,6 +515,8 @@ static const struct sfp_quirk sfp_quirks[] = {
SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc),
SFP_QUIRK_M("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
+ SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex),
+ SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-U", sfp_quirk_2500basex),
SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc),
SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc),
SFP_QUIRK_F("Turris", "RTSFP-2.5G", sfp_fixup_rollball),
---
base-commit: 9946eaf552b194bb352c2945b54ff98c8193b3f1
change-id: 20250215-lkmsub-d995d8bef400
Best regards,
--
Birger Koblitz <mail@birger-koblitz.de>
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP
2025-02-15 6:29 [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP Birger Koblitz
@ 2025-02-18 1:00 ` Jakub Kicinski
0 siblings, 0 replies; 9+ messages in thread
From: Jakub Kicinski @ 2025-02-18 1:00 UTC (permalink / raw)
To: Birger Koblitz; +Cc: netdev, Daniel Golle
On Sat, 15 Feb 2025 07:29:44 +0100 Birger Koblitz wrote:
> The OEM SFP-2.5G-BX10-D/U SFP module pair is meant to operate with
> 2500Base-X. However, in their EEPROM they incorrectly specify:
> Transceiver codes : 0x00 0x12 0x00 0x00 0x12 0x00 0x01 0x05 0x00
> BR, Nominal : 2500MBd
>
> Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway.
> Tested on BananaPi R3.
better, the patch looks correct now :)
our checkers flagged that the maintainers were not CCed:
Missing CC:
andrew@lunn.ch
linux@armlinux.org.uk
edumazet@google.com
hkallweit1@gmail.com
pabeni@redhat.com
Could you repost one more time, and make sure these addresses are CCed
(per scripts/get_maintainer.pl) ?
--
pw-bot: cr
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP
@ 2025-02-18 17:59 Birger Koblitz
2025-02-21 23:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 9+ messages in thread
From: Birger Koblitz @ 2025-02-18 17:59 UTC (permalink / raw)
To: Russell King, Andrew Lunn, Heiner Kallweit, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: netdev, linux-kernel, Birger Koblitz, Daniel Golle
The OEM SFP-2.5G-BX10-D/U SFP module pair is meant to operate with
2500Base-X. However, in their EEPROM they incorrectly specify:
Transceiver codes : 0x00 0x12 0x00 0x00 0x12 0x00 0x01 0x05 0x00
BR, Nominal : 2500MBd
Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway.
Tested on BananaPi R3.
Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
---
drivers/net/phy/sfp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index 7dbcbf0a4ee26a221e9c47a6f030c8a18317bdbb..9369f5297769493efcab0ed4c356245baa1aa248 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -515,6 +515,8 @@ static const struct sfp_quirk sfp_quirks[] = {
SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc),
SFP_QUIRK_M("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
+ SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex),
+ SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-U", sfp_quirk_2500basex),
SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc),
SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc),
SFP_QUIRK_F("Turris", "RTSFP-2.5G", sfp_fixup_rollball),
---
base-commit: f80d71e9c515163dd337d3b22b6915b1bd7b478d
change-id: 20250218-b4-lkmsub-fab17f71f9c6
Best regards,
--
Birger Koblitz <mail@birger-koblitz.de>
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP
2025-02-18 17:59 Birger Koblitz
@ 2025-02-21 23:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-02-21 23:30 UTC (permalink / raw)
To: Birger Koblitz
Cc: linux, andrew, hkallweit1, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, daniel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 18 Feb 2025 18:59:40 +0100 you wrote:
> The OEM SFP-2.5G-BX10-D/U SFP module pair is meant to operate with
> 2500Base-X. However, in their EEPROM they incorrectly specify:
> Transceiver codes : 0x00 0x12 0x00 0x00 0x12 0x00 0x01 0x05 0x00
> BR, Nominal : 2500MBd
>
> Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway.
> Tested on BananaPi R3.
>
> [...]
Here is the summary with links:
- [net-next] net: sfp: add quirk for 2.5G OEM BX SFP
https://git.kernel.org/netdev/net-next/c/a85035561025
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-02-21 23:29 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-15 6:29 [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP Birger Koblitz
2025-02-18 1:00 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2025-02-18 17:59 Birger Koblitz
2025-02-21 23:30 ` patchwork-bot+netdevbpf
2025-02-12 15:13 Birger Koblitz
2025-02-14 21:24 ` Jakub Kicinski
2025-02-09 11:01 Birger Koblitz
2025-02-09 15:13 ` Daniel Golle
2025-02-12 3:02 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).