From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: phy: realtek: add helper RTL822X_VND2_C22_REG
Date: Tue, 18 Feb 2025 06:42:44 -0800 [thread overview]
Message-ID: <20250218064244.0089ce20@kernel.org> (raw)
In-Reply-To: <31a901f6-02ed-4baa-902e-d385d1808f4b@gmail.com>
On Tue, 18 Feb 2025 07:33:32 +0100 Heiner Kallweit wrote:
> On 18.02.2025 01:44, Jakub Kicinski wrote:
> > On Fri, 14 Feb 2025 21:31:14 +0100 Heiner Kallweit wrote:
> >> -#define RTL822X_VND2_GANLPAR 0xa414
> >> +#define RTL822X_VND2_C22_REG(reg) (0xa400 + 2 * (reg))
> >
> > Just to double check - is the tab between define and RTL intentional?
>
> Yes. In the terminal a space or a tab after #define are the same,
> not sure whether there's any preference from your side.
> At least checkpatch doesn't complain.
Weak preference for following what the rest of the file does,
so space would be better. I'll change when applying.
next prev parent reply other threads:[~2025-02-18 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 20:31 [PATCH net-next] net: phy: realtek: add helper RTL822X_VND2_C22_REG Heiner Kallweit
2025-02-16 16:10 ` Andrew Lunn
2025-02-18 0:44 ` Jakub Kicinski
2025-02-18 6:33 ` Heiner Kallweit
2025-02-18 14:42 ` Jakub Kicinski [this message]
2025-02-20 11:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218064244.0089ce20@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).