From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <stfomichev@gmail.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
petrm@nvidia.com
Subject: Re: [PATCH net-next v3 3/4] selftests: drv-net: store addresses in dict indexed by ipver
Date: Tue, 18 Feb 2025 06:48:01 -0800 [thread overview]
Message-ID: <20250218064801.2b43ad83@kernel.org> (raw)
In-Reply-To: <Z7QK5BBo-ufND1yB@mini-arch>
On Mon, 17 Feb 2025 20:21:56 -0800 Stanislav Fomichev wrote:
> > > def test_v4(cfg) -> None:
> > > - cfg.require_v4()
> > > + cfg.require_ipver("4")
> > >
> > > - cmd(f"ping -c 1 -W0.5 {cfg.remote_v4}")
> > > - cmd(f"ping -c 1 -W0.5 {cfg.v4}", host=cfg.remote)
> > > + cmd(f"ping -c 1 -W0.5 {cfg.remote_addr_v["4"]}")
> > > + cmd(f"ping -c 1 -W0.5 {cfg.addr_v["4"]}", host=cfg.remote)
> >
> > Here and below, intended to use single quote around constant?
>
> Let's kick it off the testing queue as well..
>
> # overriding timeout to 90
> # selftests: drivers/net: ping.py
> # File "/home/virtme/testing-18/tools/testing/selftests/drivers/net/./ping.py", line 13
> # cmd(f"ping -c 1 -W0.5 {cfg.remote_addr_v["4"]}")
> # ^
> # SyntaxError: f-string: unmatched '['
Huh, it worked for me locally, must be a python version thing..
Python 3.13.2
>>> a={"a": ' '}
>>> f"test{a["a"]}test"
'test test'
next prev parent reply other threads:[~2025-02-18 14:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 19:41 [PATCH net-next v3 0/4] selftests: drv-net: add a simple TSO test Jakub Kicinski
2025-02-17 19:41 ` [PATCH net-next v3 1/4] selftests: drv-net: resolve remote interface name Jakub Kicinski
2025-02-17 19:41 ` [PATCH net-next v3 2/4] selftests: drv-net: get detailed interface info Jakub Kicinski
2025-02-17 19:41 ` [PATCH net-next v3 3/4] selftests: drv-net: store addresses in dict indexed by ipver Jakub Kicinski
2025-02-18 1:15 ` Willem de Bruijn
2025-02-18 4:21 ` Stanislav Fomichev
2025-02-18 14:48 ` Jakub Kicinski [this message]
2025-02-18 15:03 ` Willem de Bruijn
2025-02-17 19:42 ` [PATCH net-next v3 4/4] selftests: drv-net: add a simple TSO test Jakub Kicinski
2025-02-18 1:21 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218064801.2b43ad83@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=stfomichev@gmail.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).