Re: [PATCH v2 1/3] dt-bindings: sound: convert ICS-43432 binding to YAML

[Rob Herring <robh@kernel.org>]

On Mon, Feb 10, 2025 at 11:47:46AM +0100, Oleksij Rempel wrote:
> Convert the ICS-43432 MEMS microphone device tree binding from text format
> to YAML.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> changes v2:
> - use "enum" instead "oneOf + const"
> ---
>  .../devicetree/bindings/sound/ics43432.txt    | 19 -------
>  .../bindings/sound/invensense,ics43432.yaml   | 51 +++++++++++++++++++
>  2 files changed, 51 insertions(+), 19 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/ics43432.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/invensense,ics43432.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/ics43432.txt b/Documentation/devicetree/bindings/sound/ics43432.txt
> deleted file mode 100644
> index e6f05f2f6c4e..000000000000
> --- a/Documentation/devicetree/bindings/sound/ics43432.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -Invensense ICS-43432-compatible MEMS microphone with I2S output.
> -
> -There are no software configuration options for this device, indeed, the only
> -host connection is the I2S interface. Apart from requirements on clock
> -frequency (460 kHz to 3.379 MHz according to the data sheet) there must be
> -64 clock cycles in each stereo output frame; 24 of the 32 available bits
> -contain audio data. A hardware pin determines if the device outputs data
> -on the left or right channel of the I2S frame.
> -
> -Required properties:
> -  - compatible: should be one of the following.
> -     "invensense,ics43432": For the Invensense ICS43432
> -     "cui,cmm-4030d-261": For the CUI CMM-4030D-261-I2S-TR
> -
> -Example:
> -
> -	ics43432: ics43432 {
> -		compatible = "invensense,ics43432";
> -	};
> diff --git a/Documentation/devicetree/bindings/sound/invensense,ics43432.yaml b/Documentation/devicetree/bindings/sound/invensense,ics43432.yaml
> new file mode 100644
> index 000000000000..79ed8c8e8790
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/invensense,ics43432.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/invensense,ics43432.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Invensense ICS-43432-compatible MEMS Microphone with I2S Output
> +
> +maintainers:
> +  - N/A

If no one cares about this device, then we should just remove the 
binding and driver.

> +
> +description: |

Don't need '|' if no formatting to preserve.

> +  The ICS-43432 and compatible MEMS microphones output audio over an I2S
> +  interface and require no software configuration. The only host connection
> +  is the I2S bus. The microphone requires an I2S clock frequency between
> +  460 kHz and 3.379 MHz and 64 clock cycles per stereo frame. Each frame
> +  contains 32-bit slots per channel, with 24 bits carrying audio data.
> +  A hardware pin determines whether the microphone outputs audio on the
> +  left or right channel of the I2S frame.
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - invensense,ics43432
> +      - cui,cmm-4030d-261
> +
> +  port:
> +    $ref: audio-graph-port.yaml#
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    ics43432: ics43432 {
> +        compatible = "invensense,ics43432";
> +
> +        port {
> +          endpoint {
> +            remote-endpoint = <&i2s1_endpoint>;
> +            dai-format = "i2s";
> +          };
> +        };
> +
> +    };
> --
> 2.39.5
>