From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8295B2862B7 for ; Thu, 20 Feb 2025 02:06:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740017214; cv=none; b=QLKo56HH9HnZUzdE31kSkd9dbJkHPu8+ix6xppneSNResv+ifuI7kG16lBJpyv9xuvhKwuFWdixjpiLQAKiugB3T//EVtG6QWIqG985RaeCKZKQ5967K6Zu8w+vtBb3sXi/ZhsB/FC3vdT4ATffcK7r7YY7YIemI2p09sVtkLMI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740017214; c=relaxed/simple; bh=EgBVo6RhWMthFB+iS+hJogXI/CaL4DpuWPIXar+k6Tc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cIaPpnPNidBiGZWiw70fikzbpM49UaUMmPpgTU3CUxXBbFa7NzwnUh9Lrqyu1X9LNgL2ohwtX/pUIIyVZ88sv0HxAFtK4L/GJvDxW5baCqM7bamzZYyMD6QSx1FgxIhTZIUzjLGv7x0qffuTNXqHsdB0mn7nv1FhzkAL5Rmz6OM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S6xjXoLU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S6xjXoLU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90A9FC4CED1; Thu, 20 Feb 2025 02:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740017212; bh=EgBVo6RhWMthFB+iS+hJogXI/CaL4DpuWPIXar+k6Tc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=S6xjXoLUpWXK7RxE098FTqZiEyWwABqwy11BtNe8AGQdbyk2/FyMLvNunXJd7S4Ev rz7DC1Ia8/Umaj4uHJbBwQzhZS36a5dCynw2stcQkIFhkreFaga++/GAklJXyP5vJH +k5mhM3xuZ4UBBlqfnw1FUjrfXBN9y7/NbQqpV+D/uqZhoJ28UDduAlVb0uwgEoB1c U/Ix4qc42O1VwHcvXvgCHKBbvdRYKGGQW1oqutMbPdNeN8kg0A0jpYPHqqcBPXzaBl otryvF/MmGmz+Lc4l0mOP3wCixc83GAT0F1r74Lx/pJXgwDjO+I73p8MyZRpWBI46m ZK6ErJLlZSj+A== Date: Wed, 19 Feb 2025 18:06:51 -0800 From: Jakub Kicinski To: Kurt Kanzenbach Cc: Joe Damato , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Sebastian Andrzej Siewior , Gerhard Engleder , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up Message-ID: <20250219180651.0ea6f33d@kernel.org> In-Reply-To: <878qq22xk3.fsf@kurt.kurt.home> References: <20250217-igb_irq-v2-0-4cb502049ac2@linutronix.de> <878qq22xk3.fsf@kurt.kurt.home> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 19 Feb 2025 08:39:08 +0100 Kurt Kanzenbach wrote: > > My comment from the previous series still stands, which simply that > > I have no idea if the maintainers will accept changes using this API > > or prefer to wait until Stanislav's work [1] is completed to remove > > the RTNL requirement from this API altogether. > > I'd rather consider patch #2 a bugfix to restore the busy polling with > XDP/ZC. After commit 5ef44b3cb43b ("xsk: Bring back busy polling > support") it is a requirement to implement this API. > > The maintainers didn't speak up on v1, so i went along and sent v2. > > @Jakub: What's your preference? Would you accept this series or rather > like to wait for Stanislav's work to be finished? No strong preference. If rtnl_lock is not causing any issues in this driver, the we can merge as is. I haven't followed the past discussions, tho.