From: Nick Child <nnac123@linux.ibm.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, horms@kernel.org,
david.laight.linux@gmail.com, nick.child@ibm.com,
pmladek@suse.com, rostedt@goodmis.org, john.ogness@linutronix.de,
senozhatsky@chromium.org, Nick Child <nnac123@linux.ibm.com>
Subject: [PATCH net-next v3 2/3] hexdump: Use for_each macro in print_hex_dump
Date: Wed, 19 Feb 2025 15:11:01 -0600 [thread overview]
Message-ID: <20250219211102.225324-3-nnac123@linux.ibm.com> (raw)
In-Reply-To: <20250219211102.225324-1-nnac123@linux.ibm.com>
The looping logic in print_hex_dump can be handled by the macro
for_each_line_in_hex_dump.
Signed-off-by: Nick Child <nnac123@linux.ibm.com>
---
lib/hexdump.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/lib/hexdump.c b/lib/hexdump.c
index c3db7c3a7643..181b82dfe40d 100644
--- a/lib/hexdump.c
+++ b/lib/hexdump.c
@@ -263,19 +263,14 @@ void print_hex_dump(const char *level, const char *prefix_str, int prefix_type,
const void *buf, size_t len, bool ascii)
{
const u8 *ptr = buf;
- int i, linelen, remaining = len;
+ int i;
unsigned char linebuf[32 * 3 + 2 + 32 + 1];
if (rowsize != 16 && rowsize != 32)
rowsize = 16;
- for (i = 0; i < len; i += rowsize) {
- linelen = min(remaining, rowsize);
- remaining -= rowsize;
-
- hex_dump_to_buffer(ptr + i, linelen, rowsize, groupsize,
- linebuf, sizeof(linebuf), ascii);
-
+ for_each_line_in_hex_dump(i, rowsize, linebuf, sizeof(linebuf),
+ groupsize, buf, len) {
switch (prefix_type) {
case DUMP_PREFIX_ADDRESS:
printk("%s%s%p: %s\n",
--
2.48.1
next prev parent reply other threads:[~2025-02-19 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 21:10 [PATCH net-next v3 0/3] Use new for_each macro to create hexdumps Nick Child
2025-02-19 21:11 ` [PATCH net-next v3 1/3] hexdump: Implement macro for converting large buffers Nick Child
2025-02-20 22:00 ` David Laight
2025-02-21 17:37 ` Nick Child
2025-02-21 18:04 ` David Laight
2025-02-21 18:50 ` Nick Child
2025-02-21 22:18 ` David Laight
2025-02-22 18:58 ` Nick Child
2025-02-22 21:27 ` David Laight
2025-02-19 21:11 ` Nick Child [this message]
[not found] ` <875xl5y50q.fsf@linux.ibm.com>
2025-02-20 15:49 ` [PATCH net-next v3 2/3] hexdump: Use for_each macro in print_hex_dump Nick Child
2025-02-20 21:41 ` David Laight
2025-02-20 21:56 ` Nick Child
2025-02-19 21:11 ` [PATCH net-next v3 3/3] ibmvnic: Print data buffers with kernel API's Nick Child
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219211102.225324-3-nnac123@linux.ibm.com \
--to=nnac123@linux.ibm.com \
--cc=david.laight.linux@gmail.com \
--cc=horms@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nick.child@ibm.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).