From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F05B1FBE9E; Thu, 20 Feb 2025 14:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740061671; cv=none; b=KsBEiWDTdMGY1wXHTpddHdmiaWVRcHjjlClbVfphEfdYEl3HNZ9ekk1x6AeZyppl1L2NxlFsixfunZtgwRy/tg0PewU91B+wmWG3clXfwIst/KIOVaFWUuEhARvkTWcwAytPDa7sAoQPka6MTqrQn+GsxVOsGXpHXt1kyLPIYnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740061671; c=relaxed/simple; bh=CcFZHkvhJVv8mFkonRELBCej1lKwq1t7fxKt3ZyygZY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lDmxbgZRJyv/4UjUhW4lJyOhbylNnNvFotnha6uNQg0jieRErko1xUBGAepqBelwM/T4gDLO7HVzrDxSs1+uno/Y7S6fDrj8yyNRzqqGWCmYleWur4bKUfqzyg/o9s6RtleYa9anixzbyYZF81dl//LQwsov3Ox0qk3CcvEWiLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VQyGA8zY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VQyGA8zY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89643C4CED1; Thu, 20 Feb 2025 14:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740061671; bh=CcFZHkvhJVv8mFkonRELBCej1lKwq1t7fxKt3ZyygZY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VQyGA8zYbGA3p7s6QXn/UeT3E/Zq1QxtjFKLl+atl+tpfZDOhSwpoeVChQSsOyhCY +TbkBgqoDami5W985cE0/ltOWYNe3YT5uAybs3z0PRSt+2MWH9LZwBxEeQr5lY4T5j E3eArfq4ltyLMx4SOH+rehuiU13lq2KQoybV4y2YsXKC+TZNYA3NIULU6UY14ei8tH wPqW9IvxeizgOj0ZCQfEO1IpVjrtpdctqHdl/vD7WnzsVUUnMUJAhmdPkjC4Ofri0c x7MJ8aZuVsrXfHDVGk9WXF7z4ZIiPVC2jWioWHupIJAmUAU81ahCuSbDHYc7MlPKnR wdjHdsQ0P0hpg== Date: Thu, 20 Feb 2025 06:27:49 -0800 From: Jakub Kicinski To: "Jiri Slaby (SUSE)" Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org Subject: Re: [PATCH 03/29] tty: caif: do not use N_TTY_BUF_SIZE Message-ID: <20250220062749.4ce79a86@kernel.org> In-Reply-To: <20250220111606.138045-4-jirislaby@kernel.org> References: <20250220111606.138045-1-jirislaby@kernel.org> <20250220111606.138045-4-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 20 Feb 2025 12:15:40 +0100 Jiri Slaby (SUSE) wrote: > N_TTY_BUF_SIZE -- as the name suggests -- is the N_TTY's buffer size. > There is no reason to couple that to caif's tty->receive_room. Use 4096 > directly -- even though, it should be some sort of "SKB_MAX_ALLOC" or > alike. But definitely not N_TTY_BUF_SIZE. > > N_TTY_BUF_SIZE is private and will be moved to n_tty.c later. Acked-by: Jakub Kicinski