* [PATCH net-next] skbuff: kill skb_flow_get_ports()
@ 2025-02-18 14:37 Nicolas Dichtel
2025-02-20 10:54 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Dichtel @ 2025-02-18 14:37 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni, Eric Dumazet
Cc: netdev, Nicolas Dichtel
This function is not used anymore.
Fixes: a815bde56b15 ("net, bonding: Refactor bond_xmit_hash for use with xdp_buff")
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
include/linux/skbuff.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index bb2b751d274a..f403d43064a5 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1530,12 +1530,6 @@ u32 __skb_get_poff(const struct sk_buff *skb, const void *data,
__be32 __skb_flow_get_ports(const struct sk_buff *skb, int thoff, u8 ip_proto,
const void *data, int hlen_proto);
-static inline __be32 skb_flow_get_ports(const struct sk_buff *skb,
- int thoff, u8 ip_proto)
-{
- return __skb_flow_get_ports(skb, thoff, ip_proto, NULL, 0);
-}
-
void skb_flow_dissector_init(struct flow_dissector *flow_dissector,
const struct flow_dissector_key *key,
unsigned int key_count);
--
2.47.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] skbuff: kill skb_flow_get_ports()
2025-02-18 14:37 [PATCH net-next] skbuff: kill skb_flow_get_ports() Nicolas Dichtel
@ 2025-02-20 10:54 ` Simon Horman
2025-02-20 13:02 ` Nicolas Dichtel
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2025-02-20 10:54 UTC (permalink / raw)
To: Nicolas Dichtel
Cc: David S. Miller, Jakub Kicinski, Paolo Abeni, Eric Dumazet,
netdev
On Tue, Feb 18, 2025 at 03:37:17PM +0100, Nicolas Dichtel wrote:
> This function is not used anymore.
>
> Fixes: a815bde56b15 ("net, bonding: Refactor bond_xmit_hash for use with xdp_buff")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Reviewed-by: Simon Horman <horms@kernel.org>
I guess the churn isn't worth it, but it seems to me that
__skb_flow_get_ports could be renamed skb_flow_get_ports.
...
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] skbuff: kill skb_flow_get_ports()
2025-02-20 10:54 ` Simon Horman
@ 2025-02-20 13:02 ` Nicolas Dichtel
2025-02-20 13:15 ` Maciej Fijalkowski
0 siblings, 1 reply; 4+ messages in thread
From: Nicolas Dichtel @ 2025-02-20 13:02 UTC (permalink / raw)
To: Simon Horman
Cc: David S. Miller, Jakub Kicinski, Paolo Abeni, Eric Dumazet,
netdev
Le 20/02/2025 à 11:54, Simon Horman a écrit :
> On Tue, Feb 18, 2025 at 03:37:17PM +0100, Nicolas Dichtel wrote:
>> This function is not used anymore.
>>
>> Fixes: a815bde56b15 ("net, bonding: Refactor bond_xmit_hash for use with xdp_buff")
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>
> Reviewed-by: Simon Horman <horms@kernel.org>
>
> I guess the churn isn't worth it, but it seems to me that
> __skb_flow_get_ports could be renamed skb_flow_get_ports.
>
Right. I can send a follow-up patch.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] skbuff: kill skb_flow_get_ports()
2025-02-20 13:02 ` Nicolas Dichtel
@ 2025-02-20 13:15 ` Maciej Fijalkowski
0 siblings, 0 replies; 4+ messages in thread
From: Maciej Fijalkowski @ 2025-02-20 13:15 UTC (permalink / raw)
To: Nicolas Dichtel
Cc: Simon Horman, David S. Miller, Jakub Kicinski, Paolo Abeni,
Eric Dumazet, netdev
On Thu, Feb 20, 2025 at 02:02:05PM +0100, Nicolas Dichtel wrote:
> Le 20/02/2025 à 11:54, Simon Horman a écrit :
> > On Tue, Feb 18, 2025 at 03:37:17PM +0100, Nicolas Dichtel wrote:
> >> This function is not used anymore.
> >>
> >> Fixes: a815bde56b15 ("net, bonding: Refactor bond_xmit_hash for use with xdp_buff")
Hi, Fixes tag is redundant as this is -next material.
> >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> >
> > Reviewed-by: Simon Horman <horms@kernel.org>
> >
> > I guess the churn isn't worth it, but it seems to me that
> > __skb_flow_get_ports could be renamed skb_flow_get_ports.
> >
> Right. I can send a follow-up patch.
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-20 13:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-18 14:37 [PATCH net-next] skbuff: kill skb_flow_get_ports() Nicolas Dichtel
2025-02-20 10:54 ` Simon Horman
2025-02-20 13:02 ` Nicolas Dichtel
2025-02-20 13:15 ` Maciej Fijalkowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).