From: Jakub Kicinski <kuba@kernel.org>
To: Jiayuan Chen <jiayuan.chen@linux.dev>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
andrew+netdev@lunn.ch, davem@davemloft.ne, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, ricardo@marliere.net,
viro@zeniv.linux.org.uk, dmantipov@yandex.ru,
aleksander.lobakin@intel.com, linux-ppp@vger.kernel.org,
linux-kernel@vger.kernel.org, mrpre@163.com,
syzbot+853242d9c9917165d791@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next v1 1/1] ppp: Fix KMSAN warning by initializing 2-byte header
Date: Thu, 20 Feb 2025 15:27:03 -0800 [thread overview]
Message-ID: <20250220152703.619bf1c9@kernel.org> (raw)
In-Reply-To: <20250218133145.265313-2-jiayuan.chen@linux.dev>
On Tue, 18 Feb 2025 21:31:44 +0800 Jiayuan Chen wrote:
> - *(u8 *)skb_push(skb, 2) = 1;
> + *(u16 *)skb_push(skb, 2) = 1;
This will write the 1 to a different byte now, on big endian machines.
Probably doesn't matter but I doubt it's intentional?
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-20 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 13:31 [PATCH net-next v1 0/1] ppp: Fix KMSAN uninit-value warning Jiayuan Chen
2025-02-18 13:31 ` [PATCH net-next v1 1/1] ppp: Fix KMSAN warning by initializing 2-byte header Jiayuan Chen
2025-02-20 23:27 ` Jakub Kicinski [this message]
2025-02-21 1:48 ` Jiayuan Chen
2025-02-25 9:32 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220152703.619bf1c9@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.ne \
--cc=dmantipov@yandex.ru \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=mrpre@163.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo@marliere.net \
--cc=syzbot+853242d9c9917165d791@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).