From: Jakub Kicinski <kuba@kernel.org>
To: Meghana Malladi <m-malladi@ti.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>, <lokeshvutla@ti.com>,
<vigneshr@ti.com>, <javier.carrasco.cruz@gmail.com>,
<diogo.ivo@siemens.com>, <horms@kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <davem@davemloft.net>,
<andrew+netdev@lunn.ch>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<srk@ti.com>, Roger Quadros <rogerq@kernel.org>,
<danishanwar@ti.com>
Subject: Re: [PATCH net v2 0/2] Fixes for perout configuration in IEP driver
Date: Thu, 20 Feb 2025 17:24:10 -0800 [thread overview]
Message-ID: <20250220172410.025b96d6@kernel.org> (raw)
In-Reply-To: <415f755d-18a6-4c81-a1a7-b75d54a5886a@intel.com>
On Wed, 19 Feb 2025 15:37:16 -0800 Jacob Keller wrote:
> On 2/18/2025 10:26 PM, Meghana Malladi wrote:
> > IEP driver supports both pps and perout signal generation using testptp
> > application. Currently the driver is missing to incorporate the perout
> > signal configuration. This series introduces fixes in the driver to
> > configure perout signal based on the arguments passed by the perout
> > request.
> >
>
> This could be interpreted as a feature implementation rather than a fix.
>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Agreed, ideally we should get a patch for net which rejects
all currently (as in - in Linus's tree) unsupported settings.
That would be a fix.
Then once that's merged add support for the new settings in net-next.
Hope that makes sense?
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-21 1:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 6:26 [PATCH net v2 0/2] Fixes for perout configuration in IEP driver Meghana Malladi
2025-02-19 6:27 ` [PATCH net v2 1/2] net: ti: icss-iep: Fix pwidth configuration for perout signal Meghana Malladi
2025-02-19 6:27 ` [PATCH net v2 2/2] net: ti: icss-iep: Fix phase offset " Meghana Malladi
2025-02-19 23:37 ` [PATCH net v2 0/2] Fixes for perout configuration in IEP driver Jacob Keller
2025-02-21 1:24 ` Jakub Kicinski [this message]
2025-02-21 22:22 ` Jacob Keller
2025-03-07 23:48 ` Plan to validate supported flags in PTP core (Was: Re: [PATCH net v2 0/2] Fixes for perout configuration in IEP driver) Jacob Keller
2025-03-10 16:25 ` Jakub Kicinski
2025-03-10 21:27 ` Jacob Keller
2025-02-25 9:42 ` [PATCH net v2 0/2] Fixes for perout configuration in IEP driver Malladi, Meghana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220172410.025b96d6@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=m-malladi@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).