From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E37FD18DB0B for ; Fri, 21 Feb 2025 22:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740176812; cv=none; b=pyqfhVIMZbev78F0S2d/5z1yeGgUmZ1LwfBDTC+DEuLYfGLJfkjD1q0OeQsgvyEM6GKAHOLimYyag8Sajyn9ebUvDUIlrZVzAg/7PWMSatt0o55/XRr92sDjtnb+06wSs+OeV0Jrg7qecyGWXDicAI4m6femEttZwAwZLAbfY6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740176812; c=relaxed/simple; bh=JYIZp6oz2BlHDzWW7UOSolxuRxr9OKOgkF/GatOg+lY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rVQVjnAIbhLINwNz1BQfHSo4T9m0hVb+wAiE9qBsMii2A4ya4DdVgXtLmczlCMm0RXQZWo49Fppgbj4K2XEK15dpuUAovSRczCUDdjzUpzheHzs4vddNzvw20Fg0qSo0gMzL35UFv1U3TBLMHY1IITdfZFGdDw9CgfqVFgqnloQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OD8l3Hfp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OD8l3Hfp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06344C4CED6; Fri, 21 Feb 2025 22:26:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740176811; bh=JYIZp6oz2BlHDzWW7UOSolxuRxr9OKOgkF/GatOg+lY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OD8l3Hfp+bk5GlWSCORfoSR6mRo+OZgM44R3ssUK9650oUXRETvnC+EnhZhEc61mJ 61HQBVApFeiw2YfiptVIAlmopa0lWls5Co7c+OhX6URkkMkvuZvb8vISps6tWRHoue 7kBcp65zDc/MaDS5V+RbIsyhcbdecYt99lqXcLAS2k6Q+TTaT033ziQihS3T6f6tp+ +BmwEaRpai/QAPjeDYQFf2UkytyIhxZL8fx3ju7Pzg4ei3tBHuxuegyG5y29fdDynX LL9BdjTsnm9hkK3PRtU7u63yZsSeFQFV/1NoDiO/yX6W5mgFy/7a078Smh9rG2Tb/y 4FbpzWkM7xQgA== Date: Fri, 21 Feb 2025 14:26:50 -0800 From: Jakub Kicinski To: Joe Damato Cc: Kurt Kanzenbach , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Sebastian Andrzej Siewior , Gerhard Engleder , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up Message-ID: <20250221142650.3c74dcac@kernel.org> In-Reply-To: References: <20250217-igb_irq-v2-0-4cb502049ac2@linutronix.de> <878qq22xk3.fsf@kurt.kurt.home> <20250219180651.0ea6f33d@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 21 Feb 2025 15:53:26 -0500 Joe Damato wrote: > > No strong preference. If rtnl_lock is not causing any issues > > in this driver, the we can merge as is. I haven't followed > > the past discussions, tho. > > Don't mean to side-track this thread, but does this mean you've > changed your mind on the previous virtio_net thread [1] ? > > Or maybe I'm just misreading your response there? And instead I > could re-spin the virtio_net but dropping the first patch and > dealing with RTNL in the code like this series is doing? > > For some reason I was under the impression that the virtio_net > series and others like it (like this igb series) were being held > back until locking work Stanislav is doing is done. > > [1]: https://lore.kernel.org/netdev/20250127133756.413efb24@kernel.org/ Yes, you can probably respin v1. Let's not block this.