From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH RESUBMIT net-next] net: phy: add phylib-internal.h
Date: Fri, 21 Feb 2025 15:09:59 -0800 [thread overview]
Message-ID: <20250221150959.16c8cbbb@kernel.org> (raw)
In-Reply-To: <82e4dfdb-5140-4b8f-8f61-099a52545389@gmail.com>
On Wed, 19 Feb 2025 07:52:04 +0100 Heiner Kallweit wrote:
> +++ b/drivers/net/phy/phylib-internal.h
> @@ -0,0 +1,25 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
nit: checkpatch is displeased with the comment style:
WARNING: Improper SPDX comment style for 'drivers/net/phy/phylib-internal.h', please use '/*' instead
#100: FILE: drivers/net/phy/phylib-internal.h:1:
+// SPDX-License-Identifier: GPL-2.0-or-later
--
pw-bot: cr
prev parent reply other threads:[~2025-02-21 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 6:52 [PATCH RESUBMIT net-next] net: phy: add phylib-internal.h Heiner Kallweit
2025-02-21 23:09 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250221150959.16c8cbbb@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).