* [PATCH] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination.
@ 2025-02-20 10:29 Harshal Chaudhari
2025-02-22 0:27 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Harshal Chaudhari @ 2025-02-20 10:29 UTC (permalink / raw)
To: marcin.s.wojtas, linux, andrew+netdev, davem, edumazet, kuba,
pabeni
Cc: netdev, linux-kernel, Harshal Chaudhari
Non IP flow, with vlan tag not working as expected while
running below command for vlan-priority. fixed that.
ethtool -N eth1 flow-type ether vlan 0x8000 vlan-mask 0x1fff action 0 loc 0
Signed-off-by: Harshal Chaudhari <hchaudhari@marvell.com>
---
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
index 1641791a2d5b..8ed83fb98862 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c
@@ -324,7 +324,7 @@ static const struct mvpp2_cls_flow cls_flows[MVPP2_N_PRS_FLOWS] = {
MVPP2_PRS_RI_VLAN_MASK),
/* Non IP flow, with vlan tag */
MVPP2_DEF_FLOW(MVPP22_FLOW_ETHERNET, MVPP2_FL_NON_IP_TAG,
- MVPP22_CLS_HEK_OPT_VLAN,
+ MVPP22_CLS_HEK_TAGGED,
0, 0),
};
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination.
2025-02-20 10:29 [PATCH] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination Harshal Chaudhari
@ 2025-02-22 0:27 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2025-02-22 0:27 UTC (permalink / raw)
To: Harshal Chaudhari
Cc: marcin.s.wojtas, linux, andrew+netdev, davem, edumazet, pabeni,
netdev, linux-kernel
On Thu, 20 Feb 2025 02:29:54 -0800 Harshal Chaudhari wrote:
> Non IP flow, with vlan tag not working as expected while
> running below command for vlan-priority. fixed that.
>
> ethtool -N eth1 flow-type ether vlan 0x8000 vlan-mask 0x1fff action 0 loc 0
Thanks for the fix, one nit - please add a Fixes tag to the commit
message. See https://docs.kernel.org/process/submitting-patches.html
for the exact format of the Fixes tag we expect. The tag should refer
to the earliest commit where the problem could be triggered by a user.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-22 0:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-20 10:29 [PATCH] net: mvpp2: cls: Fixed Non IP flow, with vlan tag flow defination Harshal Chaudhari
2025-02-22 0:27 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).