From: Bjorn Helgaas <helgaas@kernel.org>
To: ChunHao Lin <hau@realtek.com>
Cc: hkallweit1@gmail.com, nic_swsd@realtek.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] r8169: disable RTL8126 ZRX-DC timeout
Date: Fri, 21 Feb 2025 14:01:32 -0600 [thread overview]
Message-ID: <20250221200132.GA357821@bhelgaas> (raw)
In-Reply-To: <20250221071828.12323-442-nic_swsd@realtek.com>
On Fri, Feb 21, 2025 at 03:18:28PM +0800, ChunHao Lin wrote:
> Disable it due to it dose not meet ZRX-DC specification. If it is enabled,
> device will exit L1 substate every 100ms. Disable it for saving more power
> in L1 substate.
s/dose/does/
Is ZRX-DC a PCIe spec? A Google search suggests that it might not be
completely Realtek-specific?
> +static void rtl_disable_zrxdc_timeout(struct rtl8169_private *tp)
> +{
> + struct pci_dev *pdev = tp->pci_dev;
> + u8 val;
> +
> + if (pdev->cfg_size > 0x0890 &&
> + pci_read_config_byte(pdev, 0x0890, &val) == PCIBIOS_SUCCESSFUL &&
> + pci_write_config_byte(pdev, 0x0890, val & ~BIT(0)) == PCIBIOS_SUCCESSFUL)
Is this a standard PCIe extended capability? If so, it would be nice
to search for it with pci_find_ext_capability() and use standard
#defines.
Bjorn
next prev parent reply other threads:[~2025-02-21 20:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 7:18 [PATCH net-next 0/3] r8169: enable more devices ASPM and LTR support ChunHao Lin
2025-02-21 7:18 ` [PATCH net-next 1/3] r8169: enable RTL8168H/RTL8168EP/RTL8168FP ASPM support ChunHao Lin
2025-02-21 19:29 ` Heiner Kallweit
2025-02-21 7:18 ` [PATCH net-next 2/3] r8169: enable RTL8168H/RTL8168EP/RTL8168FP/RTL8125/RTL8126 LTR support ChunHao Lin
2025-02-21 19:39 ` Heiner Kallweit
2025-02-24 16:33 ` Hau
2025-02-24 19:00 ` Bjorn Helgaas
2025-02-28 22:58 ` Heiner Kallweit
2025-03-06 16:51 ` Hau
2025-03-01 15:02 ` Heiner Kallweit
2025-02-21 7:18 ` [PATCH net-next 3/3] r8169: disable RTL8126 ZRX-DC timeout ChunHao Lin
2025-02-21 20:01 ` Heiner Kallweit
2025-02-24 16:09 ` Hau
2025-02-21 20:01 ` Bjorn Helgaas [this message]
2025-02-21 20:12 ` Heiner Kallweit
2025-02-21 20:35 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250221200132.GA357821@bhelgaas \
--to=helgaas@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hau@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).