* [PATCH net-next 1/3] eth: fbnic: Add PCIe registers dump
2025-02-21 20:18 [PATCH net-next 0/3] eth: fbnic: Update fbnic driver Mohsin Bashir
@ 2025-02-21 20:18 ` Mohsin Bashir
2025-02-21 20:18 ` [PATCH net-next 2/3] eth: fbnic: Consolidate PUL_USER CSR section Mohsin Bashir
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Mohsin Bashir @ 2025-02-21 20:18 UTC (permalink / raw)
To: netdev
Cc: alexanderduyck, kuba, andrew+netdev, davem, edumazet, pabeni,
jdamato, sanman.p211993, vadim.fedorenko, sdf, kernel-team,
mohsin.bashr
Provide coverage to PCIe registers in ethtool register dump
Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
---
drivers/net/ethernet/meta/fbnic/fbnic_csr.c | 1 +
drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_csr.c b/drivers/net/ethernet/meta/fbnic/fbnic_csr.c
index aeb9f333f4c7..d9c0dc1c2af9 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_csr.c
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_csr.c
@@ -30,6 +30,7 @@ static const struct fbnic_csr_bounds fbnic_csr_sects[] = {
FBNIC_BOUNDS(RSFEC),
FBNIC_BOUNDS(MAC_MAC),
FBNIC_BOUNDS(SIG),
+ FBNIC_BOUNDS(PCIE_SS_COMPHY),
FBNIC_BOUNDS(PUL_USER),
FBNIC_BOUNDS(QUEUE),
FBNIC_BOUNDS(RPC_RAM),
diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_csr.h b/drivers/net/ethernet/meta/fbnic/fbnic_csr.h
index 6f24c5f2e175..af6d33931c35 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_csr.h
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_csr.h
@@ -788,6 +788,11 @@ enum {
#define FBNIC_MAC_STAT_TX_MULTICAST_H 0x11a4b /* 0x4692c */
#define FBNIC_MAC_STAT_TX_BROADCAST_L 0x11a4c /* 0x46930 */
#define FBNIC_MAC_STAT_TX_BROADCAST_H 0x11a4d /* 0x46934 */
+
+/* PCIE Comphy Registers */
+#define FBNIC_CSR_START_PCIE_SS_COMPHY 0x2442e /* CSR section delimiter */
+#define FBNIC_CSR_END_PCIE_SS_COMPHY 0x279d7 /* CSR section delimiter */
+
/* PUL User Registers */
#define FBNIC_CSR_START_PUL_USER 0x31000 /* CSR section delimiter */
#define FBNIC_PUL_OB_TLP_HDR_AW_CFG 0x3103d /* 0xc40f4 */
--
2.43.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH net-next 2/3] eth: fbnic: Consolidate PUL_USER CSR section
2025-02-21 20:18 [PATCH net-next 0/3] eth: fbnic: Update fbnic driver Mohsin Bashir
2025-02-21 20:18 ` [PATCH net-next 1/3] eth: fbnic: Add PCIe registers dump Mohsin Bashir
@ 2025-02-21 20:18 ` Mohsin Bashir
2025-02-21 20:18 ` [PATCH net-next 3/3] eth: fbnic: Update return value in kdoc Mohsin Bashir
2025-02-25 12:10 ` [PATCH net-next 0/3] eth: fbnic: Update fbnic driver patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Mohsin Bashir @ 2025-02-21 20:18 UTC (permalink / raw)
To: netdev
Cc: alexanderduyck, kuba, andrew+netdev, davem, edumazet, pabeni,
jdamato, sanman.p211993, vadim.fedorenko, sdf, kernel-team,
mohsin.bashr
Move PUL_USER CSRs in the relevant section, update the end boundary
address, and remove the redundant definition of end boundary.
Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
---
drivers/net/ethernet/meta/fbnic/fbnic_csr.h | 73 ++++++++++-----------
1 file changed, 35 insertions(+), 38 deletions(-)
diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_csr.h b/drivers/net/ethernet/meta/fbnic/fbnic_csr.h
index af6d33931c35..3b12a0ab5906 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_csr.h
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_csr.h
@@ -799,7 +799,41 @@ enum {
#define FBNIC_PUL_OB_TLP_HDR_AW_CFG_BME CSR_BIT(18)
#define FBNIC_PUL_OB_TLP_HDR_AR_CFG 0x3103e /* 0xc40f8 */
#define FBNIC_PUL_OB_TLP_HDR_AR_CFG_BME CSR_BIT(18)
-#define FBNIC_CSR_END_PUL_USER 0x31080 /* CSR section delimiter */
+#define FBNIC_PUL_USER_OB_RD_TLP_CNT_31_0 \
+ 0x3106e /* 0xc41b8 */
+#define FBNIC_PUL_USER_OB_RD_DWORD_CNT_31_0 \
+ 0x31070 /* 0xc41c0 */
+#define FBNIC_PUL_USER_OB_RD_DWORD_CNT_63_32 \
+ 0x31071 /* 0xc41c4 */
+#define FBNIC_PUL_USER_OB_WR_TLP_CNT_31_0 \
+ 0x31072 /* 0xc41c8 */
+#define FBNIC_PUL_USER_OB_WR_TLP_CNT_63_32 \
+ 0x31073 /* 0xc41cc */
+#define FBNIC_PUL_USER_OB_WR_DWORD_CNT_31_0 \
+ 0x31074 /* 0xc41d0 */
+#define FBNIC_PUL_USER_OB_WR_DWORD_CNT_63_32 \
+ 0x31075 /* 0xc41d4 */
+#define FBNIC_PUL_USER_OB_CPL_TLP_CNT_31_0 \
+ 0x31076 /* 0xc41d8 */
+#define FBNIC_PUL_USER_OB_CPL_TLP_CNT_63_32 \
+ 0x31077 /* 0xc41dc */
+#define FBNIC_PUL_USER_OB_CPL_DWORD_CNT_31_0 \
+ 0x31078 /* 0xc41e0 */
+#define FBNIC_PUL_USER_OB_CPL_DWORD_CNT_63_32 \
+ 0x31079 /* 0xc41e4 */
+#define FBNIC_PUL_USER_OB_RD_DBG_CNT_CPL_CRED_31_0 \
+ 0x3107a /* 0xc41e8 */
+#define FBNIC_PUL_USER_OB_RD_DBG_CNT_CPL_CRED_63_32 \
+ 0x3107b /* 0xc41ec */
+#define FBNIC_PUL_USER_OB_RD_DBG_CNT_TAG_31_0 \
+ 0x3107c /* 0xc41f0 */
+#define FBNIC_PUL_USER_OB_RD_DBG_CNT_TAG_63_32 \
+ 0x3107d /* 0xc41f4 */
+#define FBNIC_PUL_USER_OB_RD_DBG_CNT_NP_CRED_31_0 \
+ 0x3107e /* 0xc41f8 */
+#define FBNIC_PUL_USER_OB_RD_DBG_CNT_NP_CRED_63_32 \
+ 0x3107f /* 0xc41fc */
+#define FBNIC_CSR_END_PUL_USER 0x310ea /* CSR section delimiter */
/* Queue Registers
*
@@ -939,43 +973,6 @@ enum {
#define FBNIC_MAX_QUEUES 128
#define FBNIC_CSR_END_QUEUE (0x40000 + 0x400 * FBNIC_MAX_QUEUES - 1)
-/* PUL User Registers*/
-#define FBNIC_PUL_USER_OB_RD_TLP_CNT_31_0 \
- 0x3106e /* 0xc41b8 */
-#define FBNIC_PUL_USER_OB_RD_DWORD_CNT_31_0 \
- 0x31070 /* 0xc41c0 */
-#define FBNIC_PUL_USER_OB_RD_DWORD_CNT_63_32 \
- 0x31071 /* 0xc41c4 */
-#define FBNIC_PUL_USER_OB_WR_TLP_CNT_31_0 \
- 0x31072 /* 0xc41c8 */
-#define FBNIC_PUL_USER_OB_WR_TLP_CNT_63_32 \
- 0x31073 /* 0xc41cc */
-#define FBNIC_PUL_USER_OB_WR_DWORD_CNT_31_0 \
- 0x31074 /* 0xc41d0 */
-#define FBNIC_PUL_USER_OB_WR_DWORD_CNT_63_32 \
- 0x31075 /* 0xc41d4 */
-#define FBNIC_PUL_USER_OB_CPL_TLP_CNT_31_0 \
- 0x31076 /* 0xc41d8 */
-#define FBNIC_PUL_USER_OB_CPL_TLP_CNT_63_32 \
- 0x31077 /* 0xc41dc */
-#define FBNIC_PUL_USER_OB_CPL_DWORD_CNT_31_0 \
- 0x31078 /* 0xc41e0 */
-#define FBNIC_PUL_USER_OB_CPL_DWORD_CNT_63_32 \
- 0x31079 /* 0xc41e4 */
-#define FBNIC_PUL_USER_OB_RD_DBG_CNT_CPL_CRED_31_0 \
- 0x3107a /* 0xc41e8 */
-#define FBNIC_PUL_USER_OB_RD_DBG_CNT_CPL_CRED_63_32 \
- 0x3107b /* 0xc41ec */
-#define FBNIC_PUL_USER_OB_RD_DBG_CNT_TAG_31_0 \
- 0x3107c /* 0xc41f0 */
-#define FBNIC_PUL_USER_OB_RD_DBG_CNT_TAG_63_32 \
- 0x3107d /* 0xc41f4 */
-#define FBNIC_PUL_USER_OB_RD_DBG_CNT_NP_CRED_31_0 \
- 0x3107e /* 0xc41f8 */
-#define FBNIC_PUL_USER_OB_RD_DBG_CNT_NP_CRED_63_32 \
- 0x3107f /* 0xc41fc */
-#define FBNIC_CSR_END_PUL_USER 0x31080 /* CSR section delimiter */
-
/* BAR 4 CSRs */
/* The IPC mailbox consists of 32 mailboxes, with each mailbox consisting
--
2.43.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH net-next 3/3] eth: fbnic: Update return value in kdoc
2025-02-21 20:18 [PATCH net-next 0/3] eth: fbnic: Update fbnic driver Mohsin Bashir
2025-02-21 20:18 ` [PATCH net-next 1/3] eth: fbnic: Add PCIe registers dump Mohsin Bashir
2025-02-21 20:18 ` [PATCH net-next 2/3] eth: fbnic: Consolidate PUL_USER CSR section Mohsin Bashir
@ 2025-02-21 20:18 ` Mohsin Bashir
2025-02-25 12:10 ` [PATCH net-next 0/3] eth: fbnic: Update fbnic driver patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Mohsin Bashir @ 2025-02-21 20:18 UTC (permalink / raw)
To: netdev
Cc: alexanderduyck, kuba, andrew+netdev, davem, edumazet, pabeni,
jdamato, sanman.p211993, vadim.fedorenko, sdf, kernel-team,
mohsin.bashr
Fix return value in kdoc for fbnic_netdev_alloc()
Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
---
drivers/net/ethernet/meta/fbnic/fbnic_netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
index cf8feb90b617..79a01fdd1dd1 100644
--- a/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
+++ b/drivers/net/ethernet/meta/fbnic/fbnic_netdev.c
@@ -611,7 +611,7 @@ void fbnic_netdev_free(struct fbnic_dev *fbd)
* Allocate and initialize the netdev and netdev private structure. Bind
* together the hardware, netdev, and pci data structures.
*
- * Return: 0 on success, negative on failure
+ * Return: Pointer to net_device on success, NULL on failure
**/
struct net_device *fbnic_netdev_alloc(struct fbnic_dev *fbd)
{
--
2.43.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next 0/3] eth: fbnic: Update fbnic driver
2025-02-21 20:18 [PATCH net-next 0/3] eth: fbnic: Update fbnic driver Mohsin Bashir
` (2 preceding siblings ...)
2025-02-21 20:18 ` [PATCH net-next 3/3] eth: fbnic: Update return value in kdoc Mohsin Bashir
@ 2025-02-25 12:10 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-02-25 12:10 UTC (permalink / raw)
To: Mohsin Bashir
Cc: netdev, alexanderduyck, kuba, andrew+netdev, davem, edumazet,
pabeni, jdamato, sanman.p211993, vadim.fedorenko, sdf,
kernel-team
Hello:
This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 21 Feb 2025 12:18:10 -0800 you wrote:
> This patchset makes following trivial changes to the fbnic driver:
> 1) Add coverage for PCIe CSRs in the ethtool register dump.
>
> 2) Consolidate the PUL_USER CSR section, update the end boundary,
> and remove redundant definition of the end boundary.
>
> 3) Update the return value in kdoc for fbnic_netdev_alloc().
>
> [...]
Here is the summary with links:
- [net-next,1/3] eth: fbnic: Add PCIe registers dump
https://git.kernel.org/netdev/net-next/c/c6aa4e2cdff6
- [net-next,2/3] eth: fbnic: Consolidate PUL_USER CSR section
https://git.kernel.org/netdev/net-next/c/e4e7c9be2117
- [net-next,3/3] eth: fbnic: Update return value in kdoc
https://git.kernel.org/netdev/net-next/c/26aa7992b456
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread