From: Jakub Kicinski <kuba@kernel.org>
To: Mohammad Heib <mheib@redhat.com>
Cc: netdev@vger.kernel.org, benve@cisco.com, satishkh@cisco.com
Subject: Re: [PATCH net] enic: Avoid removing IPv6 address when updating rings size.
Date: Mon, 24 Feb 2025 13:18:43 -0800 [thread overview]
Message-ID: <20250224131843.4ef2307d@kernel.org> (raw)
In-Reply-To: <20250223214203.2159676-1-mheib@redhat.com>
On Sun, 23 Feb 2025 23:42:03 +0200 Mohammad Heib wrote:
> To avoid this behavior, this patch temporarily sets the interface config
> `keep_addr_on_down` to 1 before closing the device during the rings
> update, and restores the original value of `keep_addr_on_down` after
> updating the device rings, this will prevent the ipv6 stack from
> removing the current ipv6 addresses during the rings update.
Wrong direction, you should support reconfiguration natively
in the driver. Pre-allocate all the resources for the new config
and swap it with the running one.
--
pw-bot: cr
prev parent reply other threads:[~2025-02-24 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-23 21:42 [PATCH net] enic: Avoid removing IPv6 address when updating rings size Mohammad Heib
2025-02-24 11:16 ` Michal Schmidt
2025-02-24 21:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224131843.4ef2307d@kernel.org \
--to=kuba@kernel.org \
--cc=benve@cisco.com \
--cc=mheib@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=satishkh@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).