From: Jakub Kicinski <kuba@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
<shenjian15@huawei.com>, <wangpeiyang1@huawei.com>,
<liuyonglong@huawei.com>, <chenhao418@huawei.com>,
<sudongming1@huawei.com>, <xujunsheng@huawei.com>,
<shiyongbang@huawei.com>, <libaihan@huawei.com>,
<jonathan.cameron@huawei.com>,
<shameerali.kolothum.thodi@huawei.com>, <salil.mehta@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [PATCH v3 net-next 2/6] net: hibmcge: Add support for rx checksum offload
Date: Tue, 25 Feb 2025 08:23:06 -0800 [thread overview]
Message-ID: <20250225082306.524e8d6a@kernel.org> (raw)
In-Reply-To: <641ddf73-3497-433b-baf4-f7189384d19b@huawei.com>
On Tue, 25 Feb 2025 17:00:45 +0800 Jijie Shao wrote:
> >> + NETIF_F_RXCSUM)
> > I don't see you setting the checksum to anything other than NONE
>
> When receiving packets, MAC checks the checksum by default. This behavior cannot be disabled.
> If the checksum is incorrect, the MAC notifies the driver through the descriptor.
>
> If checksum offload is enabled, the driver drops the packet.
> Otherwise, the driver set the checksum to NONE and sends the packet to the stack.
Dropping packets with bad csum is not correct.
Packets where device validated L4 csum should have csum set
to UNNECESSARY, most likely. Please read the comment in skbuff.h
next prev parent reply other threads:[~2025-02-25 16:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 11:55 [PATCH v3 net-next 0/6] Support some enhances features for the HIBMCGE driver Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 1/6] net: hibmcge: Add support for dump statistics Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 2/6] net: hibmcge: Add support for rx checksum offload Jijie Shao
2025-02-25 3:09 ` Jakub Kicinski
2025-02-25 9:00 ` Jijie Shao
2025-02-25 16:23 ` Jakub Kicinski [this message]
2025-02-27 11:28 ` Jijie Shao
2025-02-27 14:47 ` Jakub Kicinski
2025-02-28 1:04 ` Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 3/6] net: hibmcge: Add support for abnormal irq handling feature Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 4/6] net: hibmcge: Add support for mac link exception " Jijie Shao
2025-02-25 3:09 ` Jakub Kicinski
2025-02-25 8:37 ` Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 5/6] net: hibmcge: Add support for BMC diagnose feature Jijie Shao
2025-02-21 11:55 ` [PATCH v3 net-next 6/6] net: hibmcge: Add support for ioctl Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225082306.524e8d6a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).