From: Simon Horman <horms@kernel.org>
To: Pablo Martin Medrano <pablmart@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH net v2] selftests/net: big_tcp: return xfail on slow machines
Date: Tue, 25 Feb 2025 10:24:36 +0000 [thread overview]
Message-ID: <20250225102436.GT1615191@kernel.org> (raw)
In-Reply-To: <38aad71b-db71-d502-9ce6-9bf2efd5a717@redhat.com>
On Mon, Feb 24, 2025 at 06:34:55PM +0100, Pablo Martin Medrano wrote:
>
>
> On Mon, 24 Feb 2025, Simon Horman wrote:
>
> > Hi Pablo,
> >
> > FWIIW, I think this can be moved to below the scissors ("---").
> >
> > Checkpatch complains that fixes tags should have 12 or more characters of
> > sha1 hash.
> >
> > Fixes: a19747c3b9bf ("selftests: net: let big_tcp test cope with slow env")
>
> Thank you Simon! I will modify this for the next version. Looks like I am
> falling in all the stones possible for my first patch :) Receiving such a
> friendly support is great.
Perhaps there are too many stones :)
> > Lastly, and most importantly, it seems that there is new feedback on a
> > predecessor of this patch, which probably needs to be addressed.
>
> Addressing it. Thank you for pointing it out!
next prev parent reply other threads:[~2025-02-25 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 17:07 [PATCH net v2] selftests/net: big_tcp: return xfail on slow machines Pablo Martin Medrano
2025-02-24 13:44 ` Simon Horman
2025-02-24 17:34 ` Pablo Martin Medrano
2025-02-25 10:24 ` Simon Horman [this message]
2025-02-25 12:56 ` Petr Machata
2025-02-26 17:32 ` Pablo Martin Medrano
2025-02-25 13:01 ` Petr Machata
2025-02-26 18:53 ` Pablo Martin Medrano
2025-02-27 10:42 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225102436.GT1615191@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablmart@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).