From: kernel test robot <lkp@intel.com>
To: Cindy Lu <lulu@redhat.com>,
jasowang@redhat.com, mst@redhat.com, michael.christie@oracle.com,
sgarzare@redhat.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v6 3/6] vhost: Add the cgroup related function
Date: Tue, 25 Feb 2025 10:35:23 +0800 [thread overview]
Message-ID: <202502251038.6UlCIMJy-lkp@intel.com> (raw)
In-Reply-To: <20250223154042.556001-4-lulu@redhat.com>
Hi Cindy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on v6.14-rc3]
[also build test WARNING on linus/master next-20250224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Cindy-Lu/vhost-Add-a-new-parameter-in-vhost_dev-to-allow-user-select-kthread/20250223-234405
base: v6.14-rc3
patch link: https://lore.kernel.org/r/20250223154042.556001-4-lulu%40redhat.com
patch subject: [PATCH v6 3/6] vhost: Add the cgroup related function
config: x86_64-buildonly-randconfig-002-20250224 (https://download.01.org/0day-ci/archive/20250225/202502251038.6UlCIMJy-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250225/202502251038.6UlCIMJy-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502251038.6UlCIMJy-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/vhost/vhost.c:275: warning: Function parameter or struct member 'ignore_attachment' not described in '__vhost_worker_flush'
vim +275 drivers/vhost/vhost.c
0921dddcb589803 Mike Christie 2023-06-26 266
228a27cf78afc63 Mike Christie 2023-06-26 267 /**
ba704ff4e142fd3 Mike Christie 2024-03-15 268 * __vhost_worker_flush - flush a worker
228a27cf78afc63 Mike Christie 2023-06-26 269 * @worker: worker to flush
228a27cf78afc63 Mike Christie 2023-06-26 270 *
ba704ff4e142fd3 Mike Christie 2024-03-15 271 * The worker's flush_mutex must be held.
228a27cf78afc63 Mike Christie 2023-06-26 272 */
84e88426e3bc18f Cindy Lu 2025-02-23 273 static void __vhost_worker_flush(struct vhost_worker *worker,
84e88426e3bc18f Cindy Lu 2025-02-23 274 bool ignore_attachment)
a6fc04739be7cd8 Mike Christie 2023-06-26 @275 {
228a27cf78afc63 Mike Christie 2023-06-26 276 struct vhost_flush_struct flush;
228a27cf78afc63 Mike Christie 2023-06-26 277
84e88426e3bc18f Cindy Lu 2025-02-23 278 if ((!ignore_attachment && !worker->attachment_cnt) || worker->killed)
ba704ff4e142fd3 Mike Christie 2024-03-15 279 return;
ba704ff4e142fd3 Mike Christie 2024-03-15 280
228a27cf78afc63 Mike Christie 2023-06-26 281 init_completion(&flush.wait_event);
228a27cf78afc63 Mike Christie 2023-06-26 282 vhost_work_init(&flush.work, vhost_flush_work);
228a27cf78afc63 Mike Christie 2023-06-26 283
228a27cf78afc63 Mike Christie 2023-06-26 284 vhost_worker_queue(worker, &flush.work);
ba704ff4e142fd3 Mike Christie 2024-03-15 285 /*
ba704ff4e142fd3 Mike Christie 2024-03-15 286 * Drop mutex in case our worker is killed and it needs to take the
ba704ff4e142fd3 Mike Christie 2024-03-15 287 * mutex to force cleanup.
ba704ff4e142fd3 Mike Christie 2024-03-15 288 */
ba704ff4e142fd3 Mike Christie 2024-03-15 289 mutex_unlock(&worker->mutex);
228a27cf78afc63 Mike Christie 2023-06-26 290 wait_for_completion(&flush.wait_event);
ba704ff4e142fd3 Mike Christie 2024-03-15 291 mutex_lock(&worker->mutex);
ba704ff4e142fd3 Mike Christie 2024-03-15 292 }
ba704ff4e142fd3 Mike Christie 2024-03-15 293
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-02-25 2:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-23 15:36 [PATCH v6 0/6] vhost: Add support of kthread API Cindy Lu
2025-02-23 15:36 ` [PATCH v6 1/6] vhost: Add a new parameter in vhost_dev to allow user select kthread Cindy Lu
2025-02-24 1:36 ` Jason Wang
2025-02-23 15:36 ` [PATCH v6 2/6] vhost: Reintroduce vhost_worker to support kthread Cindy Lu
2025-02-24 1:36 ` Jason Wang
2025-02-23 15:36 ` [PATCH v6 3/6] vhost: Add the cgroup related function Cindy Lu
2025-02-24 1:39 ` Jason Wang
2025-02-26 2:15 ` Cindy Lu
2025-02-25 2:35 ` kernel test robot [this message]
2025-02-23 15:36 ` [PATCH v6 4/6] vhost: introduce worker ops to support multiple thread models Cindy Lu
2025-02-24 1:44 ` Jason Wang
2025-02-26 2:06 ` Cindy Lu
2025-02-23 15:36 ` [PATCH v6 5/6] vhost: Add new UAPI to support change to task mode Cindy Lu
2025-02-24 1:54 ` Jason Wang
2025-02-24 21:41 ` Michael S. Tsirkin
2025-02-24 21:46 ` Michael S. Tsirkin
2025-02-26 6:16 ` Cindy Lu
2025-02-25 11:31 ` Stefano Garzarella
2025-02-26 6:13 ` Cindy Lu
2025-02-26 8:46 ` Stefano Garzarella
2025-02-26 8:50 ` Michael S. Tsirkin
2025-02-26 9:02 ` Stefano Garzarella
2025-02-26 9:05 ` Stefano Garzarella
2025-02-26 9:19 ` Cindy Lu
2025-02-23 15:36 ` [PATCH v6 6/6] vhost: Add check for inherit_owner status Cindy Lu
2025-02-24 1:56 ` Jason Wang
2025-02-24 15:13 ` [PATCH v6 0/6] vhost: Add support of kthread API Lei Yang
2025-02-24 21:43 ` Michael S. Tsirkin
2025-02-26 2:04 ` Cindy Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502251038.6UlCIMJy-lkp@intel.com \
--to=lkp@intel.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).