From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 471CB21ABC2 for ; Tue, 25 Feb 2025 15:08:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740496091; cv=none; b=fGkT23OXkhr14LpgU4yLh5QYEdPWdWR2vVWwgj7BWAqLCR0j0L71FMz1YS97RBASLBwM31XPyIyqLdctxW2nzfbTyZm28eaLAsdKllY5MHAnYQkuDw5tKnSEkE8or14+VIg4Xrth2WoVz7oTsMhMHqIC5BVLhNxV2oi4NKekz74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740496091; c=relaxed/simple; bh=IbCTGBLnXSlV+G4vQ7LBQedicGv33RSpdl3CE0jDfRw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YZq9OR6s/gU+3HXocoCb4VKWJiZ0E4+JnU1PRqM9NTLkC1fJrNCFuEaNcIUHAO1FE3277Zxd4xceSViuMgpUwmDMMGTnDLIN+wcAnDb1Yp1sLCmHkcrBVVmPpGPXNgSxkKBqU4nVU6NNveUeZBodCp48ZDaJLjMEq8A0u3IW1k8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rVc/oR7d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rVc/oR7d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A596DC4CEDD; Tue, 25 Feb 2025 15:08:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740496090; bh=IbCTGBLnXSlV+G4vQ7LBQedicGv33RSpdl3CE0jDfRw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rVc/oR7ddhu8AxKtcy0EyzkuV/eMKmDxhGN3OUJ3alx/+F6Sv/RX5mnC5ibVRkpPy 3DX9R+Mg5Q0t/j0DFyU0fe8zGgQIX7aGZnOamndDznH1iuRQ37KTpVmBixnLs8Wy8z VCWKv62AhAbWly3rZYkNNIy7egrzsuUAJJgFVo840gGHmWCCdZJDgtc9PwtOXq9q8b WwJvZo4q6UKgyNxTGn9ODn1Gn/GCLn9Dc4mxfUKdJavkR/8gjqlvUDf8MVK0GxFWxI NJ7iK/GVyu4wQZJMzIcqt6jDvll7Ff3uULPsrdzdr5TlVo4MDVimIuAZL7/DSCNIlw kddkPowX3zpuQ== Date: Tue, 25 Feb 2025 15:08:07 +0000 From: Simon Horman To: Grzegorz Nitka Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Karol Kolacinski , Przemek Kitszel Subject: Re: [PATCH iwl-next v1 2/3] ice: refactor ice_sbq_msg_dev enum Message-ID: <20250225150807.GB1615191@kernel.org> References: <20250221123123.2833395-1-grzegorz.nitka@intel.com> <20250221123123.2833395-3-grzegorz.nitka@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250221123123.2833395-3-grzegorz.nitka@intel.com> On Fri, Feb 21, 2025 at 01:31:22PM +0100, Grzegorz Nitka wrote: > From: Karol Kolacinski > > Rename ice_sbq_msg_dev to ice_sbq_dev_id to reflect the meaning of this > type more precisely. This enum type describes RDA (Remote Device Access) > client ids, accessible over SB (Side Band) interface. > Rename enum elements to make a driver namespace more cleaner and > consistent with other definitions within SB > Remove unused 'rmn_x' entries, specific to unsupported E824 device. > Adjust clients '2' and '13' names (phy_0 and phy_0_peer respectively) to > be compliant with EAS doc. According to the specification, regardless of > the complex entity (single or dual), when accessing its own ports, > they're accessed always as 'phy_0' client. And referred as 'phy_0_peer' > when handling ports conneced to the other complex. > > Reviewed-by: Przemek Kitszel > Signed-off-by: Karol Kolacinski > Co-developed-by: Grzegorz Nitka > Signed-off-by: Grzegorz Nitka Reviewed-by: Simon Horman