Re: [PATCH net-next v5 07/14] xsc: Init auxiliary device

[Jakub Kicinski <kuba@kernel.org>]

On Tue, 25 Feb 2025 01:24:31 +0800 Xin Tian wrote:
> Our device supports both Ethernet and RDMA functionalities, and
> leveraging the auxiliary bus perfectly addresses our needs for
> managing these distinct features. This patch utilizes auxiliary
> device to handle the Ethernet functionality, while defining
> xsc_adev_list to reserve expansion space for future RDMA
> capabilities.

drivers/net/ethernet/yunsilicon/xsc/pci/adev.c:90:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
   90 |         if (adev_id < 0)
      |             ^~~~~~~~~~~
drivers/net/ethernet/yunsilicon/xsc/pci/adev.c:104:9: note: uninitialized use occurs here
  104 |         return ret;
      |                ^~~
drivers/net/ethernet/yunsilicon/xsc/pci/adev.c:90:2: note: remove the 'if' if its condition is always false
   90 |         if (adev_id < 0)
      |         ^~~~~~~~~~~~~~~~
   91 |                 goto err_free_adev_list;
      |                 ~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/yunsilicon/xsc/pci/adev.c:82:9: note: initialize the variable 'ret' to silence this warning
   82 |         int ret;
      |                ^
      |                 = 0
-- 
pw-bot: cr