netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <kuba@kernel.org>
Cc: <davem@davemloft.net>, <dsahern@kernel.org>,
	<edumazet@google.com>, <horms@kernel.org>, <kuni1840@gmail.com>,
	<kuniyu@amazon.com>, <netdev@vger.kernel.org>,
	<pabeni@redhat.com>
Subject: Re: [PATCH v1 net-next 00/12] ipv4: fib: Convert RTM_NEWROUTE and RTM_DELROUTE to per-netns RTNL.
Date: Tue, 25 Feb 2025 16:46:57 -0800	[thread overview]
Message-ID: <20250226004657.36987-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250225162448.3a3c4133@kernel.org>

From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 25 Feb 2025 16:24:48 -0800
> On Tue, 25 Feb 2025 10:22:38 -0800 Kuniyuki Iwashima wrote:
> > Patch 1 is a misc cleanup.
> > Patch 2 ~ 8 converts two fib_info hash tables to per-netns.
> > Patch 9 ~ 12 converts rtnl_lock() to rtnl_net_lcok().
> 
> Breaks quite a few tests :(

Oh, sorry... why I didn't notice this silly mistake :/
I enabled kmemleak on my debug config.
Will fix in v2.

---8<---
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index b9ead0257340..34cfea5c127b 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -1666,7 +1666,7 @@ static void __net_exit fib_net_exit(struct net *net)
 {
 	fib_proc_exit(net);
 	nl_fib_lookup_exit(net);
-	fib4_semantics_init(net);
+	fib4_semantics_exit(net);
 }
 
 static void __net_exit fib_net_exit_batch(struct list_head *net_list)
---8<---


> 
> unreferenced object 0xffff88800bfc6800 (size 256):
>   comm "ip", pid 577, jiffies 4294699578
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
>   backtrace (crc 0):
>     __kmalloc_node_noprof+0x35d/0x4a0
>     fib4_semantics_init+0x25/0xf0
>     fib_net_init+0x17e/0x340

      reply	other threads:[~2025-02-26  0:47 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 18:22 [PATCH v1 net-next 00/12] ipv4: fib: Convert RTM_NEWROUTE and RTM_DELROUTE to per-netns RTNL Kuniyuki Iwashima
2025-02-25 18:22 ` [PATCH v1 net-next 01/12] ipv4: fib: Use cached net in fib_inetaddr_event() Kuniyuki Iwashima
2025-02-26 10:39   ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 02/12] ipv4: fib: Allocate fib_info_hash[] and fib_info_laddrhash[] by kvmalloc_array() Kuniyuki Iwashima
2025-02-26 11:08   ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 03/12] ipv4: fib: Allocate fib_info_hash[] during netns initialisation Kuniyuki Iwashima
2025-02-26 11:10   ` Eric Dumazet
2025-02-26 17:48   ` David Ahern
2025-02-26 18:09     ` Eric Dumazet
2025-02-26 18:12       ` David Ahern
2025-02-26 18:20         ` Kuniyuki Iwashima
2025-02-25 18:22 ` [PATCH v1 net-next 04/12] ipv4: fib: Make fib_info_hashfn() return struct hlist_head Kuniyuki Iwashima
2025-02-26 11:13   ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 05/12] ipv4: fib: Remove fib_info_laddrhash pointer Kuniyuki Iwashima
2025-02-26 11:15   ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 06/12] ipv4: fib: Remove fib_info_hash_size Kuniyuki Iwashima
2025-02-26 11:16   ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 07/12] ipv4: fib: Add fib_info_hash_grow() Kuniyuki Iwashima
2025-02-26 11:18   ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 08/12] ipv4: fib: Namespacify fib_info hash tables Kuniyuki Iwashima
2025-02-26 11:22   ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 09/12] ipv4: fib: Hold rtnl_net_lock() for ip_fib_net_exit() Kuniyuki Iwashima
2025-02-26 11:23   ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 10/12] ipv4: fib: Hold rtnl_net_lock() in ip_rt_ioctl() Kuniyuki Iwashima
2025-02-26 14:42   ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 11/12] ipv4: fib: Move fib_valid_key_len() to rtm_to_fib_config() Kuniyuki Iwashima
2025-02-26 14:43   ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 12/12] ipv4: fib: Convert RTM_NEWROUTE and RTM_DELROUTE to per-netns RTNL Kuniyuki Iwashima
2025-02-26 14:45   ` Eric Dumazet
2025-02-26  0:24 ` [PATCH v1 net-next 00/12] " Jakub Kicinski
2025-02-26  0:46   ` Kuniyuki Iwashima [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250226004657.36987-1-kuniyu@amazon.com \
    --to=kuniyu@amazon.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuni1840@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).