From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Shenwei Wang <shenwei.wang@nxp.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Wei Fang <wei.fang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH net-next] net: enetc: Support ethernet aliases in dts.
Date: Wed, 26 Feb 2025 17:10:10 +0200 [thread overview]
Message-ID: <20250226151010.u2jj5n6e3ofbed6p@skbuf> (raw)
In-Reply-To: <PAXPR04MB91856660FC7E8BF3A8356D7889C22@PAXPR04MB9185.eurprd04.prod.outlook.com>
On Wed, Feb 26, 2025 at 05:07:15PM +0200, Shenwei Wang wrote:
> > -----Original Message-----
> > From: Andrew Lunn <andrew@lunn.ch>
> > Sent: Wednesday, February 26, 2025 8:58 AM
> > To: Shenwei Wang <shenwei.wang@nxp.com>
> > Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; Vladimir Oltean
> > <vladimir.oltean@nxp.com>; Wei Fang <wei.fang@nxp.com>; Clark Wang
> > <xiaoning.wang@nxp.com>; Andrew Lunn <andrew+netdev@lunn.ch>; David S.
> > Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> > Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>;
> > imx@lists.linux.dev; netdev@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> > Subject: [EXT] Re: [PATCH net-next] net: enetc: Support ethernet aliases in dts.
> > On Tue, Feb 25, 2025 at 03:44:58PM -0600, Shenwei Wang wrote:
> > > Retrieve the "ethernet" alias ID from the DTS and assign it as the
> > > interface name (e.g., "eth0", "eth1"). This ensures predictable naming
> > > aligned with the DTS's configuration.
> > >
> > > If no alias is defined, fall back to the kernel's default enumeration
> > > to maintain backward compatibility.
> >
> > GregKH and others will tell you this is a user space problem. Ethernet names have
> > never been stable, user space has always had to deal with this problem. Please
> > use a udev rule, systemd naming, etc.
>
> Thanks Andrew.
> Does it mean the ethernet aliases defined in the dts are no longer recommended or supported?
>
> Thanks,
> Shenwei
Aliases are recommended at least for U-Boot fixups of any kind (MAC
addresses, but not necessarily). You never want to perform a fixup based
on a hardcoded node path.
next prev parent reply other threads:[~2025-02-26 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 21:44 [PATCH net-next] net: enetc: Support ethernet aliases in dts Shenwei Wang
2025-02-26 14:57 ` Andrew Lunn
2025-02-26 15:07 ` Shenwei Wang
2025-02-26 15:10 ` Vladimir Oltean [this message]
2025-02-26 15:47 ` Vladimir Oltean
2025-02-26 16:46 ` Shenwei Wang
2025-02-26 17:10 ` Vladimir Oltean
2025-02-26 17:43 ` Shenwei Wang
2025-02-26 20:02 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226151010.u2jj5n6e3ofbed6p@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox