From: Jakub Kicinski <kuba@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings
Date: Wed, 26 Feb 2025 17:25:19 -0800 [thread overview]
Message-ID: <20250226172519.11767ac9@kernel.org> (raw)
In-Reply-To: <Z79iP0glNCZOznu4@x130>
On Wed, 26 Feb 2025 10:49:35 -0800 Saeed Mahameed wrote:
> On 26 Feb 13:47, Gustavo A. R. Silva wrote:
> >-struct mlx5e_umr_wqe {
> >+struct mlx5e_umr_wqe_hdr {
> > struct mlx5_wqe_ctrl_seg ctrl;
> > struct mlx5_wqe_umr_ctrl_seg uctrl;
> > struct mlx5_mkey_seg mkc;
> >+};
> >+
> >+struct mlx5e_umr_wqe {
> >+ struct mlx5e_umr_wqe_hdr hdr;
>
> You missed or ignored my comment on v0, anyway:
>
> Can we have struct mlx5e_umr_wq_hdr defined anonymously within
> mlx5e_umr_wqe? Let's avoid namespace pollution.
It's also used in struct mlx5e_rq, I don't think it can be anonymous?
next prev parent reply other threads:[~2025-02-27 1:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 3:17 [PATCH v3][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2025-02-26 18:49 ` Saeed Mahameed
2025-02-27 1:25 ` Jakub Kicinski [this message]
2025-02-27 22:27 ` Saeed Mahameed
2025-02-27 1:36 ` Gustavo A. R. Silva
2025-02-27 22:29 ` Saeed Mahameed
2025-02-28 1:29 ` patchwork-bot+netdevbpf
2025-02-28 1:37 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226172519.11767ac9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=leon@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).