* [PATCH net] netkit: Remove double invocation to clear ipvs property flag
@ 2025-02-25 21:29 Daniel Borkmann
2025-02-26 9:48 ` Nikolay Aleksandrov
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Daniel Borkmann @ 2025-02-25 21:29 UTC (permalink / raw)
To: kuba; +Cc: netdev, bpf, Philo Lu, Nikolay Aleksandrov, Martin KaFai Lau
With ipvs_reset() now done unconditionally in skb_scrub_packet()
we would then call the former twice netkit_prep_forward(). Thus
remove the now unnecessary explicit call.
Fixes: de2c211868b9 ("ipvs: Always clear ipvs_property flag in skb_scrub_packet()")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Philo Lu <lulie@linux.alibaba.com>
Cc: Nikolay Aleksandrov <razor@blackwall.org>
Cc: Martin KaFai Lau <martin.lau@kernel.org>
---
[ Sending to net since de2c211868b9 is in net ]
drivers/net/netkit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/netkit.c b/drivers/net/netkit.c
index 1e1b00756be7..20088f781376 100644
--- a/drivers/net/netkit.c
+++ b/drivers/net/netkit.c
@@ -65,7 +65,6 @@ static void netkit_prep_forward(struct sk_buff *skb,
skb_reset_mac_header(skb);
if (!xnet)
return;
- ipvs_reset(skb);
skb_clear_tstamp(skb);
if (xnet_scrub)
netkit_xnet(skb);
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net] netkit: Remove double invocation to clear ipvs property flag
2025-02-25 21:29 [PATCH net] netkit: Remove double invocation to clear ipvs property flag Daniel Borkmann
@ 2025-02-26 9:48 ` Nikolay Aleksandrov
2025-02-27 1:33 ` Jakub Kicinski
2025-02-28 1:29 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: Nikolay Aleksandrov @ 2025-02-26 9:48 UTC (permalink / raw)
To: Daniel Borkmann, kuba; +Cc: netdev, bpf, Philo Lu, Martin KaFai Lau
On 2/25/25 23:29, Daniel Borkmann wrote:
> With ipvs_reset() now done unconditionally in skb_scrub_packet()
> we would then call the former twice netkit_prep_forward(). Thus
> remove the now unnecessary explicit call.
>
> Fixes: de2c211868b9 ("ipvs: Always clear ipvs_property flag in skb_scrub_packet()")
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Philo Lu <lulie@linux.alibaba.com>
> Cc: Nikolay Aleksandrov <razor@blackwall.org>
> Cc: Martin KaFai Lau <martin.lau@kernel.org>
> ---
> [ Sending to net since de2c211868b9 is in net ]
>
> drivers/net/netkit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/netkit.c b/drivers/net/netkit.c
> index 1e1b00756be7..20088f781376 100644
> --- a/drivers/net/netkit.c
> +++ b/drivers/net/netkit.c
> @@ -65,7 +65,6 @@ static void netkit_prep_forward(struct sk_buff *skb,
> skb_reset_mac_header(skb);
> if (!xnet)
> return;
> - ipvs_reset(skb);
> skb_clear_tstamp(skb);
> if (xnet_scrub)
> netkit_xnet(skb);
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net] netkit: Remove double invocation to clear ipvs property flag
2025-02-25 21:29 [PATCH net] netkit: Remove double invocation to clear ipvs property flag Daniel Borkmann
2025-02-26 9:48 ` Nikolay Aleksandrov
@ 2025-02-27 1:33 ` Jakub Kicinski
2025-02-27 7:22 ` Daniel Borkmann
2025-02-28 1:29 ` patchwork-bot+netdevbpf
2 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2025-02-27 1:33 UTC (permalink / raw)
To: Daniel Borkmann
Cc: netdev, bpf, Philo Lu, Nikolay Aleksandrov, Martin KaFai Lau
On Tue, 25 Feb 2025 22:29:27 +0100 Daniel Borkmann wrote:
> With ipvs_reset() now done unconditionally in skb_scrub_packet()
> we would then call the former twice netkit_prep_forward(). Thus
> remove the now unnecessary explicit call.
>
> Fixes: de2c211868b9 ("ipvs: Always clear ipvs_property flag in skb_scrub_packet()")
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Philo Lu <lulie@linux.alibaba.com>
> Cc: Nikolay Aleksandrov <razor@blackwall.org>
> Cc: Martin KaFai Lau <martin.lau@kernel.org>
> ---
> [ Sending to net since de2c211868b9 is in net ]
I see. But if that's okay with you we'll apply it to net-next tomorrow,
once the trees converge?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net] netkit: Remove double invocation to clear ipvs property flag
2025-02-27 1:33 ` Jakub Kicinski
@ 2025-02-27 7:22 ` Daniel Borkmann
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Borkmann @ 2025-02-27 7:22 UTC (permalink / raw)
To: Jakub Kicinski
Cc: netdev, bpf, Philo Lu, Nikolay Aleksandrov, Martin KaFai Lau
On 2/27/25 2:33 AM, Jakub Kicinski wrote:
> On Tue, 25 Feb 2025 22:29:27 +0100 Daniel Borkmann wrote:
>> With ipvs_reset() now done unconditionally in skb_scrub_packet()
>> we would then call the former twice netkit_prep_forward(). Thus
>> remove the now unnecessary explicit call.
>>
>> Fixes: de2c211868b9 ("ipvs: Always clear ipvs_property flag in skb_scrub_packet()")
>> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
>> Cc: Philo Lu <lulie@linux.alibaba.com>
>> Cc: Nikolay Aleksandrov <razor@blackwall.org>
>> Cc: Martin KaFai Lau <martin.lau@kernel.org>
>> ---
>> [ Sending to net since de2c211868b9 is in net ]
>
> I see. But if that's okay with you we'll apply it to net-next tomorrow,
> once the trees converge?
Yes, that's totally fine, too. Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net] netkit: Remove double invocation to clear ipvs property flag
2025-02-25 21:29 [PATCH net] netkit: Remove double invocation to clear ipvs property flag Daniel Borkmann
2025-02-26 9:48 ` Nikolay Aleksandrov
2025-02-27 1:33 ` Jakub Kicinski
@ 2025-02-28 1:29 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-02-28 1:29 UTC (permalink / raw)
To: Daniel Borkmann; +Cc: kuba, netdev, bpf, lulie, razor, martin.lau
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 25 Feb 2025 22:29:27 +0100 you wrote:
> With ipvs_reset() now done unconditionally in skb_scrub_packet()
> we would then call the former twice netkit_prep_forward(). Thus
> remove the now unnecessary explicit call.
>
> Fixes: de2c211868b9 ("ipvs: Always clear ipvs_property flag in skb_scrub_packet()")
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Philo Lu <lulie@linux.alibaba.com>
> Cc: Nikolay Aleksandrov <razor@blackwall.org>
> Cc: Martin KaFai Lau <martin.lau@kernel.org>
>
> [...]
Here is the summary with links:
- [net] netkit: Remove double invocation to clear ipvs property flag
https://git.kernel.org/netdev/net-next/c/047e059cf212
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-28 1:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-25 21:29 [PATCH net] netkit: Remove double invocation to clear ipvs property flag Daniel Borkmann
2025-02-26 9:48 ` Nikolay Aleksandrov
2025-02-27 1:33 ` Jakub Kicinski
2025-02-27 7:22 ` Daniel Borkmann
2025-02-28 1:29 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).