From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <dsahern@kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <horms@kernel.org>,
<kuba@kernel.org>, <kuni1840@gmail.com>, <kuniyu@amazon.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH v1 net-next 03/12] ipv4: fib: Allocate fib_info_hash[] during netns initialisation.
Date: Wed, 26 Feb 2025 10:20:19 -0800 [thread overview]
Message-ID: <20250226182019.98268-1-kuniyu@amazon.com> (raw)
In-Reply-To: <a0a1ee91-b557-4721-9d35-a7914f75ed2b@kernel.org>
From: David Ahern <dsahern@kernel.org>
Date: Wed, 26 Feb 2025 11:12:13 -0700
> On 2/26/25 11:09 AM, Eric Dumazet wrote:
> >>> @@ -1627,6 +1633,8 @@ static int __net_init fib_net_init(struct net *net)
> >>> out_proc:
> >>> nl_fib_lookup_exit(net);
> >>> out_nlfl:
> >>> + fib4_semantics_init(net);
> >>
> >> _exit?
> >
> > Yes, this was mentioned yesterday.
>
> not in this code path but rather fib_net_exit. Hence me pointing out
> this one only
Sorry, actually I realised the path and fixed just after sending the
diff yesterday.
Will send v2 shortly.
Thank you both for the review !
next prev parent reply other threads:[~2025-02-26 18:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 18:22 [PATCH v1 net-next 00/12] ipv4: fib: Convert RTM_NEWROUTE and RTM_DELROUTE to per-netns RTNL Kuniyuki Iwashima
2025-02-25 18:22 ` [PATCH v1 net-next 01/12] ipv4: fib: Use cached net in fib_inetaddr_event() Kuniyuki Iwashima
2025-02-26 10:39 ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 02/12] ipv4: fib: Allocate fib_info_hash[] and fib_info_laddrhash[] by kvmalloc_array() Kuniyuki Iwashima
2025-02-26 11:08 ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 03/12] ipv4: fib: Allocate fib_info_hash[] during netns initialisation Kuniyuki Iwashima
2025-02-26 11:10 ` Eric Dumazet
2025-02-26 17:48 ` David Ahern
2025-02-26 18:09 ` Eric Dumazet
2025-02-26 18:12 ` David Ahern
2025-02-26 18:20 ` Kuniyuki Iwashima [this message]
2025-02-25 18:22 ` [PATCH v1 net-next 04/12] ipv4: fib: Make fib_info_hashfn() return struct hlist_head Kuniyuki Iwashima
2025-02-26 11:13 ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 05/12] ipv4: fib: Remove fib_info_laddrhash pointer Kuniyuki Iwashima
2025-02-26 11:15 ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 06/12] ipv4: fib: Remove fib_info_hash_size Kuniyuki Iwashima
2025-02-26 11:16 ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 07/12] ipv4: fib: Add fib_info_hash_grow() Kuniyuki Iwashima
2025-02-26 11:18 ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 08/12] ipv4: fib: Namespacify fib_info hash tables Kuniyuki Iwashima
2025-02-26 11:22 ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 09/12] ipv4: fib: Hold rtnl_net_lock() for ip_fib_net_exit() Kuniyuki Iwashima
2025-02-26 11:23 ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 10/12] ipv4: fib: Hold rtnl_net_lock() in ip_rt_ioctl() Kuniyuki Iwashima
2025-02-26 14:42 ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 11/12] ipv4: fib: Move fib_valid_key_len() to rtm_to_fib_config() Kuniyuki Iwashima
2025-02-26 14:43 ` Eric Dumazet
2025-02-25 18:22 ` [PATCH v1 net-next 12/12] ipv4: fib: Convert RTM_NEWROUTE and RTM_DELROUTE to per-netns RTNL Kuniyuki Iwashima
2025-02-26 14:45 ` Eric Dumazet
2025-02-26 0:24 ` [PATCH v1 net-next 00/12] " Jakub Kicinski
2025-02-26 0:46 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226182019.98268-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).