From: Kevin Krakauer <krakauer@google.com>
To: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org,
Kevin Krakauer <krakauer@google.com>
Subject: [PATCH v2 2/3] selftests/net: only print passing message in GRO tests when tests pass
Date: Wed, 26 Feb 2025 11:27:24 -0800 [thread overview]
Message-ID: <20250226192725.621969-3-krakauer@google.com> (raw)
In-Reply-To: <20250226192725.621969-1-krakauer@google.com>
gro.c:main no longer erroneously claims a test passes when running as a
sender.
Tested: Ran `gro.sh -t large` to verify the sender no longer prints a
status.
Signed-off-by: Kevin Krakauer <krakauer@google.com>
---
tools/testing/selftests/net/gro.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/gro.c b/tools/testing/selftests/net/gro.c
index b2184847e388..d5824eadea10 100644
--- a/tools/testing/selftests/net/gro.c
+++ b/tools/testing/selftests/net/gro.c
@@ -1318,11 +1318,13 @@ int main(int argc, char **argv)
read_MAC(src_mac, smac);
read_MAC(dst_mac, dmac);
- if (tx_socket)
+ if (tx_socket) {
gro_sender();
- else
+ } else {
+ /* Only the receiver exit status determines test success. */
gro_receiver();
+ fprintf(stderr, "Gro::%s test passed.\n", testname);
+ }
- fprintf(stderr, "Gro::%s test passed.\n", testname);
return 0;
}
--
2.48.1.658.g4767266eb4-goog
next prev parent reply other threads:[~2025-02-26 19:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 19:27 [PATCH v2 0/3] selftests/net: deflake GRO tests and fix return value and output Kevin Krakauer
2025-02-26 19:27 ` [PATCH v2 1/3] selftests/net: have `gro.sh -t` return a correct exit code Kevin Krakauer
2025-02-27 16:20 ` Willem de Bruijn
2025-02-27 21:25 ` Kevin Krakauer
2025-02-27 21:31 ` Willem de Bruijn
2025-02-26 19:27 ` Kevin Krakauer [this message]
2025-02-27 16:20 ` [PATCH v2 2/3] selftests/net: only print passing message in GRO tests when tests pass Willem de Bruijn
2025-02-26 19:27 ` [PATCH v2 3/3] selftests/net: deflake GRO tests Kevin Krakauer
2025-02-27 16:14 ` Willem de Bruijn
2025-02-27 16:36 ` [PATCH v2 0/3] selftests/net: deflake GRO tests and fix return value and output Willem de Bruijn
2025-02-28 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226192725.621969-3-krakauer@google.com \
--to=krakauer@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).